Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: runtime/dart-runtime.gyp

Issue 11434106: Part of fix for http://dartbug.com/6528 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/libdart_dependency_helper.cc » ('j') | runtime/vm/libdart_dependency_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/dart-runtime.gyp
diff --git a/runtime/dart-runtime.gyp b/runtime/dart-runtime.gyp
index 58defcbb46c40b0c84e4a375ce5bed53df7e55cc..d3520bec46ba62907cb49f4ec0030393c93e648d 100644
--- a/runtime/dart-runtime.gyp
+++ b/runtime/dart-runtime.gyp
@@ -50,29 +50,20 @@
{
'target_name': 'generate_version_cc_file',
'type': 'none',
- # The dependencies here are the union of the dependencies of libdart and
- # libdart_withcore. The produced libraries need to be listed individually
- # as inputs, otherwise the action will not be run when one of the
- # libraries is rebuilt.
- #'dependencies': [
- # 'libdart_lib_withcore',
- # 'libdart_lib',
- # 'libdart_vm',
- # 'libjscre',
- # 'libdouble_conversion',
- #],
- 'actions': [
+ 'dependencies': [
+ 'libdart_dependency_helper',
+ ],
+ 'actions': [
{
'action_name': 'generate_version_cc',
'inputs': [
'tools/make_version.py',
'../tools/VERSION',
'<(version_in_cc_file)',
- #'<(LIB_DIR)/<(STATIC_LIB_PREFIX)dart_lib_withcore<(STATIC_LIB_SUFFIX)',
- #'<(LIB_DIR)/<(STATIC_LIB_PREFIX)dart_lib<(STATIC_LIB_SUFFIX)',
- #'<(LIB_DIR)/<(STATIC_LIB_PREFIX)dart_vm<(STATIC_LIB_SUFFIX)',
- #'<(LIB_DIR)/<(STATIC_LIB_PREFIX)jscre<(STATIC_LIB_SUFFIX)',
- #'<(LIB_DIR)/<(STATIC_LIB_PREFIX)double_conversion<(STATIC_LIB_SUFFIX)',
+ # We need to list the libdart_dependency_helper executable here otherwise
ahe 2012/12/04 15:33:58 Long line.
kustermann 2012/12/05 09:08:53 Done.
+ # the action doesn't get executed if any of libdart/libdart_withcore
ahe 2012/12/04 15:33:58 It is not only libdart/libdart_withcore. Also, th
kustermann 2012/12/05 09:08:53 Done.
+ # changes
+ '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)libdart_dependency_helper<(EXECUTABLE_SUFFIX)',
],
'outputs': [
'<(version_cc_file)',
@@ -89,6 +80,22 @@
],
},
{
+ 'target_name': 'libdart_dependency_helper',
+ 'type': 'executable',
+ # The dependencies here are the union of the dependencies of libdart and
+ # libdart_withcore.
+ 'dependencies': [
+ 'libdart_lib_withcore',
+ 'libdart_lib',
+ 'libdart_vm',
+ 'libjscre',
+ 'libdouble_conversion',
+ ],
+ 'sources': [
+ 'vm/libdart_dependency_helper.cc',
+ ],
+ },
+ {
'target_name': 'runtime_packages',
'type': 'none',
'dependencies': [
« no previous file with comments | « no previous file | runtime/vm/libdart_dependency_helper.cc » ('j') | runtime/vm/libdart_dependency_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698