Issue 11434098: incremental link for interactive_ui_tests on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11434098: incremental link for interactive_ui_tests on windows (Closed)

Created:
8 years ago by scottmg

Modified:
8 years ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

incremental link for interactive_ui_tests on windows Move print_preview_test because it's only used in unit_tests, and update as-a-result unneeded dependency on test_shell_test_support. R=jam@chromium.org TEST=interactive_ui_tests, unit_tests, and browser_tests link Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170882

Patch Set 1 #

Patch Set 2 : fix properly #

Patch Set 3 : more tidying #

Patch Set 4 : fix for ios #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	chrome/browser/plugins/plugin_prefs_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	3 chunks	+9 lines, -10 lines	1 comment	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 3	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

had to leave test_shell_test_support in browser_tests because it depends on MockPluginList via other tests too ...

8 years ago (2012-12-04 02:11:02 UTC) #2

jam

8 years ago (2012-12-04 16:16:47 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/11434098/diff/1003/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/11434098/diff/1003/chrome/chrome_tests.gypi#n...
chrome/chrome_tests.gypi:804: '../webkit/webkit.gyp:test_shell_test_support',
btw I don't think this should have moved? i.e. this isn't a runtime dependency?

Expand Messages | Collapse Messages