Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tests/language/factory_implementation_test.dart

Issue 11434089: Update or delete language tests using obsolete interfaces or default factory (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/factory5_test.dart ('k') | tests/language/factory_negative_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/factory_implementation_test.dart
===================================================================
--- tests/language/factory_implementation_test.dart (revision 15648)
+++ tests/language/factory_implementation_test.dart (working copy)
@@ -1,13 +1,13 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-interface A default B {
- A(int x, int y);
+abstract class A {
+ factory A(int x, int y) = B;
}
-interface X default B {
- X(int x, int y);
+abstract class X {
+ factory X(int x, int y) = B.X;
}
class XImpl implements X {
@@ -16,7 +16,6 @@
XImpl(this.x, this.y);
}
-// new A invokes B constructor because B implements A.
class B implements A {
final int x;
final int y;
@@ -24,19 +23,19 @@
B(this.x, this.y);
// This factory will never be invoked.
// TODO(ahe): Is this a compile time error?
- factory A(int a, int b) { return new B(0, 0); }
+ factory B.A(int a, int b) { return new B(0, 0); }
- factory X(int a, int b) { return new XImpl(a * 10, b * 10); }
+ factory B.X(int a, int b) { return new XImpl(a * 10, b * 10); }
}
main() {
var a = new A(1, 2);
- // Check that constructor B is invoked and not factory A.
+ // Check that constructor B is invoked and not factory B.A.
Expect.equals(1, a.x);
Expect.equals(2, a.y);
- var x = new X(11, 22);
+ var x = new X(11, 22); /// 00: dynamic type error
// Check that factory is invoked.
- Expect.equals(110, x.x);
- Expect.equals(220, x.y);
+ Expect.equals(110, x.x); /// 00: continued
+ Expect.equals(220, x.y); /// 00: continued
}
« no previous file with comments | « tests/language/factory5_test.dart ('k') | tests/language/factory_negative_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698