Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Unified Diff: cc/surfaces/surface_aggregator.h

Issue 1143403003: Calculate damage rects before aggregating frame data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixremap
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/surfaces/surface_aggregator.cc » ('j') | cc/surfaces/surface_aggregator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_aggregator.h
diff --git a/cc/surfaces/surface_aggregator.h b/cc/surfaces/surface_aggregator.h
index d9466680113be22536aaa195fd05221a7e1d4c58..127a71b69db4a22177308a1228c58d14122ff510 100644
--- a/cc/surfaces/surface_aggregator.h
+++ b/cc/surfaces/surface_aggregator.h
@@ -72,14 +72,13 @@ class CC_SURFACES_EXPORT SurfaceAggregator {
const ClipData& clip_rect,
RenderPass* dest_pass,
SurfaceId surface_id);
+ gfx::Rect ValidateAndCalculateDamageRect(SurfaceId surface_id);
void CopyPasses(const DelegatedFrameData* frame_data, Surface* surface);
// Remove Surfaces that were referenced before but aren't currently
// referenced from the ResourceProvider.
void RemoveUnreferencedChildren();
- bool ValidateResources(Surface* surface,
- const DelegatedFrameData* frame_data);
int ChildIdForSurface(Surface* surface);
gfx::Rect DamageRectForSurface(const Surface* surface,
const RenderPass& source,
@@ -111,6 +110,10 @@ class CC_SURFACES_EXPORT SurfaceAggregator {
SurfaceIndexMap previous_contained_surfaces_;
SurfaceIndexMap contained_surfaces_;
+ // For every Surface referenced in current frame is true if it's valid
+ // (resource references are consistent) and false if it isn't.
+ base::hash_map<SurfaceId, bool> surface_validity_;
danakj 2015/07/06 22:08:43 how about a hash_set and you're valid if you're in
jbauman 2015/07/06 23:08:15 Done.
+
// This is the pass list for the aggregated frame.
RenderPassList* dest_pass_list_;
« no previous file with comments | « no previous file | cc/surfaces/surface_aggregator.cc » ('j') | cc/surfaces/surface_aggregator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698