Support extension highlighting on the extensions page.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   'use strict';
 
   /**
    * A lookup helper function to find the first node that has an id (starting
    * at |node| and going up the parent chain).
@@ skipping 32 matching lines @@
     },
 
     /**
      * Creates all extension items from scratch.
      * @private
      */
     showExtensionNodes_: function() {
       // Iterate over the extension data and add each item to the list.
       this.data_.extensions.forEach(this.createNode_, this);
 
+      var id_to_highlight = this.extensionIdToHighlight();
+      if (id_to_highlight)
+        $(id_to_highlight).scrollIntoView();

[Finnur, 2012/11/29 04:07:34]

After fighting with this for a while I'm ready to pull the plug on this
scrolling, since it doesn't work too well -- items scrolled to are usually
partly off-screen. :/

[Aaron Boodman, 2012/11/29 21:39:40]

Is it because of the heading layer? You can get the actual scroll offset with
element.scrollTop and then add the height of the heading with
headingElement.offsetHeight. You'd probably need some spacing too.

+
       if (this.data_.extensions.length == 0)
         this.classList.add('empty-extension-list');
       else
         this.classList.remove('empty-extension-list');
     },
 
     /**
      * Synthesizes and initializes an HTML element for the extension metadata
      * given in |extension|.
      * @param {Object} extension A dictionary of extension metadata.
      * @private
      */
     createNode_: function(extension) {
       var template = $('template-collection').querySelector(
           '.extension-list-item-wrapper');
       var node = template.cloneNode(true);
       node.id = extension.id;
 
       if (!extension.enabled || extension.terminated)
         node.classList.add('inactive-extension');
 
       if (!extension.userModifiable)
         node.classList.add('may-not-disable');
 
+      if (node.id == this.extensionIdToHighlight())
+        node.classList.add('extension-highlight');
+
       var item = node.querySelector('.extension-list-item');
       item.style.backgroundImage = 'url(' + extension.icon + ')';
 
       var title = node.querySelector('.extension-title');
       title.textContent = extension.name;
 
       var version = node.querySelector('.extension-version');
       version.textContent = extension.version;
 
       var disableReason = node.querySelector('.extension-disable-reason');
@@ skipping 186 matching lines @@
         panel.hidden = false;
         var list = panel.querySelector('ul');
         extension.installWarnings.forEach(function(warning) {
           var li = document.createElement('li');
           li[warning.isHTML ? 'innerHTML' : 'innerText'] = warning.message;
           list.appendChild(li);
         });
       }
 
       this.appendChild(node);
+    },
+
+    /**
+     * Returns the extension id of the extension to highlight, if any.
+     * @private
+     */
+    extensionIdToHighlight: function() {

[Aaron Boodman, 2012/11/29 21:39:40]

See parseQueryParams() in browser/resources/shared/js/util.js

+      var queryString = location.search.substring(1).split('&');
+      for (var i = 0; i < queryString.length; ++i) {
+        var param = queryString[i].split('=');
+        if (param[0] == 'id' && param.length > 1)
+          return param[1];
+      }
+      return '';
     }
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });