Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 11434013: In Chrome ASH on Windows 8 make sure that the browser object is closed before destroying it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.cc
===================================================================
--- chrome/browser/ui/views/frame/browser_view.cc (revision 169752)
+++ chrome/browser/ui/views/frame/browser_view.cc (working copy)
@@ -552,6 +552,13 @@
// notifications will call back into deleted objects).
download_shelf_.reset();
+#if defined(OS_WIN) && defined(USE_AURA)
+ // Chrome ASH on Windows 8 could be closed with open browser windows.
+ // Make sure that we close the browser window before destroying it.
+ if (!browser_->tab_strip_model()->empty())
sky 2012/11/28 22:44:57 This seems wrong. What code path is letting us get
+ browser_->OnWindowClosing();
+#endif
+
// The TabStrip attaches a listener to the model. Make sure we shut down the
// TabStrip first so that it can cleanly remove the listener.
if (tabstrip_) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698