Ensure that NSS HTTP IO is initialized on iOS.

chrome/browser/io_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/io_thread.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 49 matching lines @@
 #include "net/proxy/proxy_service.h"
 #include "net/spdy/spdy_session.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_throttler_manager.h"
 #include "net/websockets/websocket_job.h"
 
 #if defined(ENABLE_CONFIGURATION_POLICY)
 #include "policy/policy_constants.h"
 #endif
 
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)

[Nico, 2012/12/01 01:41:21]

Is NSS used on IOS? If so, should USE_NSS be set when building on ios? That
seems simpler.

[wtc, 2012/12/01 02:19:43]

NSS is used on iOS to verify certificates. The test
    #if defined(USE_NSS) || defined(OS_IOS)
identifies the platforms where we use NSS to verify certificates.

The meaning of USE_NSS changed several times. The current
meaning of USE_NSS is roughly "use the system NSS libraries".
If USE_NSS is not defined, then we either
1. use our own copy of NSS, or
2. use OpenSSL.

iOS falls under case 1 -- Chrome for iOS contains its own copy
of NSS. So we cannot define USE_NSS for iOS.

If we want to clean up this mess, I think we can do the following.
- Rename USE_NSS to USE_SYSTEM_NSS.
- Add a new macro VERIFY_CERTS_WITH_NSS, which is defined
  if USE_SYSTEM_NSS is defined or OS_IOS is defined.

But that will be a separate (big) CL.

 #include "net/ocsp/nss_ocsp.h"
-#endif  // defined(USE_NSS)
+#endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/proxy_config_service_impl.h"
 #endif  // defined(OS_CHROMEOS)
 
 using content::BrowserThread;
 
 class SafeBrowsingURLRequestContext;
 
 // The IOThread object must outlive any tasks posted to the IO thread before the
 // Quit task, so base::Bind() calls are not refcounted.
 
 namespace {
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
 void ObserveKeychainEvents() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   net::CertDatabase::GetInstance()->SetMessageLoopForKeychainEvents();
 }
 #endif
 
 // Used for the "system" URLRequestContext.
 class SystemURLRequestContext : public net::URLRequestContext {
  public:
   SystemURLRequestContext() {
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
     net::SetURLRequestContextForNSSHttpIO(this);
-#endif  // defined(USE_NSS)
+#endif
   }
 
  private:
   virtual ~SystemURLRequestContext() {
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
     net::SetURLRequestContextForNSSHttpIO(NULL);
-#endif  // defined(USE_NSS)
+#endif
   }
 };
 
 scoped_ptr<net::HostResolver> CreateGlobalHostResolver(net::NetLog* net_log) {
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
 
   net::HostResolver::Options options;
 
   // Use the concurrency override from the command-line, if any.
   if (command_line.HasSwitch(switches::kHostResolverParallelism)) {
@@ skipping 311 matching lines @@
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (!system_url_request_context_getter_) {
     InitSystemRequestContext();
   }
   return system_url_request_context_getter_;
 }
 
 void IOThread::Init() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
   net::SetMessageLoopForNSSHttpIO();
-#endif  // defined(USE_NSS)
+#endif
 
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
 
   DCHECK(!globals_);
   globals_ = new Globals;
 
   // Add an observer that will emit network change events to the ChromeNetLog.
   // Assuming NetworkChangeNotifier dispatches in FIFO order, we should be
   // logging the network change before other IO thread consumers respond to it.
   network_change_observer_.reset(
@@ skipping 115 matching lines @@
   // error.
   weak_factory_.DetachFromThread();
 }
 
 void IOThread::CleanUp() {
   base::debug::LeakTracker<SafeBrowsingURLRequestContext>::CheckForLeaks();
 
   delete sdch_manager_;
   sdch_manager_ = NULL;
 
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
   net::ShutdownNSSHttpIO();
-#endif  // defined(USE_NSS)
+#endif
 
   system_url_request_context_getter_ = NULL;
 
   // Release objects that the net::URLRequestContext could have been pointing
   // to.
 
   // This must be reset before the ChromeNetLog is destroyed.
   network_change_observer_.reset();
 
   system_proxy_config_service_.reset();
@@ skipping 254 matching lines @@
   globals_->system_request_context.reset(
       ConstructSystemRequestContext(globals_, net_log_));
 
   sdch_manager_->set_sdch_fetcher(
       new SdchDictionaryFetcher(system_url_request_context_getter_.get()));
 }
 
 void IOThread::UpdateDnsClientEnabled() {
   globals()->host_resolver->SetDnsClientEnabled(*dns_client_enabled_);
 }