Ensure that NSS HTTP IO is initialized on iOS.

net/url_request/url_request_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shlobj.h>
 #endif
@@ skipping 1312 matching lines @@
 TEST_F(URLRequestTest, RequestCompletionForEmptyResponse) {
   TestDelegate d;
   URLRequest req(GURL("data:,"), &d, &default_context_);
   req.Start();
   MessageLoop::current()->Run();
   EXPECT_EQ("", d.data_received());
   EXPECT_EQ(1, default_network_delegate_.completed_requests());
 }
 
 // TODO(droger): Support TestServer on iOS (see http://crbug.com/148666).
 #if !defined(OS_IOS)

[droger, 2012/11/29 08:32:26]

Disabled tests on iOS.

 // A subclass of TestServer that uses a statically-configured hostname. This is
 // to work around mysterious failures in chrome_frame_net_tests. See:
 // http://crbug.com/114369
 class LocalHttpTestServer : public TestServer {
  public:
   explicit LocalHttpTestServer(const FilePath& document_root)
       : TestServer(TestServer::TYPE_HTTP,
                    ScopedCustomUrlRequestTestHttpHost::value(),
                    document_root) {}
   LocalHttpTestServer()
@@ skipping 3112 matching lines @@
 
   virtual void SetUp() OVERRIDE {
     SetupContext(&context_);
     context_.Init();
 
     scoped_refptr<net::X509Certificate> root_cert =
       ImportCertFromFile(GetTestCertsDirectory(), "ocsp-test-root.pem");
     CHECK_NE(static_cast<X509Certificate*>(NULL), root_cert);
     test_root_.reset(new ScopedTestRoot(root_cert));
 
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
     SetURLRequestContextForNSSHttpIO(&context_);
     EnsureNSSHttpIOInit();
 #endif
   }
 
   void DoConnection(const TestServer::SSLOptions& ssl_options,
                     CertStatus* out_cert_status) {
     TestServer test_server(TestServer::TYPE_HTTPS,
                            ssl_options,
                            FilePath(FILE_PATH_LITERAL("net/data/ssl")));
     ASSERT_TRUE(test_server.Start());
 
     TestDelegate d;
     d.set_allow_certificate_errors(true);
     URLRequest r(test_server.GetURL(""), &d, &context_);
     r.Start();
 
     MessageLoop::current()->Run();
 
     EXPECT_EQ(1, d.response_started_count());
     *out_cert_status = r.ssl_info().cert_status;
   }
 
   ~HTTPSOCSPTest() {
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
     ShutdownNSSHttpIO();
 #endif

[Ryan Sleevi, 2012/11/28 21:56:13]

Are these tests somehow disabled on iOS? I suspect that they're falling into the
OS_MACOSX rules and thus not running.

If so, more than OS_MACOSX needs to be updated here in this file.

[droger, 2012/11/29 08:32:26]

Some tests in this file are disabled on iOS because we don't have the test
server.
See comment above.

[wtc, 2012/11/29 19:24:33]

I don't know what you meant by "the OS_MACOSX rules". I
searched for "OS_MACOSX" and "OS X" in this file and fixed
all the problems I spotted. Please take a look at patch set
2.

   }
 
  protected:
   // SetupContext configures the URLRequestContext that will be used for making
   // connetions to testserver. This can be overridden in test subclasses for
   // different behaviour.
   virtual void SetupContext(URLRequestContext* context) {
     context->set_ssl_config_service(
         new TestSSLConfigService(true /* check for EV */,
                                  true /* online revocation checking */));
@@ skipping 609 matching lines @@
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d->response_started_count());
     EXPECT_FALSE(d->received_data_before_response());
     EXPECT_EQ(d->bytes_received(), static_cast<int>(file_size));
   }
 }
 #endif  // !defined(DISABLE_FTP_SUPPORT)
 
 }  // namespace net