gpu/command_buffer/service/feature_info.cc - Issue 1143393007: Teach GPU command buffer whether a context is webgl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 1143393007: Teach GPU command buffer whether a context is webgl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/context_group.h ('K') | « gpu/command_buffer/service/context_group_unittest.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/feature_info.cc

diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc

index c86de231fd4695af0574699fbab0570a12d47675..d692b546ed4885cc1f536207cd212eb0a3a4b518 100644

--- a/gpu/command_buffer/service/feature_info.cc

+++ b/gpu/command_buffer/service/feature_info.cc

@@ -523,10 +523,11 @@ void FeatureInfo::InitializeFeatures() {

}

// Check if we should allow GL_OES_texture_npot

- if (gl_version_info_->is_es3 ||

- gl_version_info_->is_desktop_core_profile ||

- extensions.Contains("GL_ARB_texture_non_power_of_two") ||

- extensions.Contains("GL_OES_texture_npot")) {

+ if (!disallowed_features_.npot_support &&

+ (gl_version_info_->is_es3 ||

+ gl_version_info_->is_desktop_core_profile ||

+ extensions.Contains("GL_ARB_texture_non_power_of_two") ||

+ extensions.Contains("GL_OES_texture_npot"))) {

AddExtensionString("GL_OES_texture_npot");

feature_flags_.npot_ok = true;

}