Update docs for builders.pyl format, part 1.

Update docs for builders.pyl format, part 1.

This removes the mention of the 'master_type' field and updates
the 'git_repo_url', 'buildbucket_bucket', and 'service_account_file'
field descriptions.

R=nodir@chromium.org, pgervais@chromium.org
BUG=492876
Committed: https://chromium.googlesource.com/infra/infra/+/aa8e2e15f274784fef16133bbd158df5a33e1520

[Dirk Pranke, 2015-05-29 01:52:36]

This is some doc cleanup prior to the main change to add new scheduler types.

[Dirk Pranke, 2015-05-29 01:53:10]

The matching code CL is in https://codereview.chromium.org/1153203003/ ; it is
unfortunate that these are in two different repos.

[nodir, 2015-05-29 03:39:45]

https://codereview.chromium.org/1143393004/diff/1/doc/source/user_guide/build...
File doc/source/user_guide/builders_pyl.rst (right):

https://codereview.chromium.org/1143393004/diff/1/doc/source/user_guide/build...
doc/source/user_guide/builders_pyl.rst:89: are tryservers or triggered from
other bots).
s/bots/masters ?

https://codereview.chromium.org/1143393004/diff/1/doc/source/user_guide/build...
doc/source/user_guide/builders_pyl.rst:92: created for this buildbot. If it is
not set, it defaults to `None`.
Please add that by convention the bucket name is master name, e.g.
master.tryserver.nacl

https://codereview.chromium.org/1143393004/diff/1/doc/source/user_guide/build...
doc/source/user_guide/builders_pyl.rst:126: use to connect to buildbucket. If
not set, it defaults to `None`.
A reader may find this ambiguous: it is not clear whether the attribute value
should include the directory.

I'd not mention the exact directory, so we don't have to update sync these docs.


Please mention that filename format is "service-account-<name>.json", where
<name> is often project name, like chromium or nacl.

[Dirk Pranke, 2015-05-29 17:22:07]

https://codereview.chromium.org/1143393004/diff/1/doc/source/user_guide/build...
File doc/source/user_guide/builders_pyl.rst (right):

https://codereview.chromium.org/1143393004/diff/1/doc/source/user_guide/build...
doc/source/user_guide/builders_pyl.rst:89: are tryservers or triggered from
other bots).
On 2015/05/29 03:39:45, nodir wrote:
> s/bots/masters ?

I'll rework this somehow; masters is a bit confusing as well.

https://codereview.chromium.org/1143393004/diff/1/doc/source/user_guide/build...
doc/source/user_guide/builders_pyl.rst:92: created for this buildbot. If it is
not set, it defaults to `None`.
On 2015/05/29 03:39:44, nodir wrote:
> Please add that by convention the bucket name is master name, e.g.
> master.tryserver.nacl

Will do.

https://codereview.chromium.org/1143393004/diff/1/doc/source/user_guide/build...
doc/source/user_guide/builders_pyl.rst:126: use to connect to buildbucket. If
not set, it defaults to `None`.
On 2015/05/29 03:39:45, nodir wrote:
> A reader may find this ambiguous: it is not clear whether the attribute value
> should include the directory.
> 
> I'd not mention the exact directory, so we don't have to update sync these
docs.
> 
> 
> Please mention that filename format is "service-account-<name>.json", where
> <name> is often project name, like chromium or nacl.

Will update.

[Dirk Pranke, 2015-05-29 20:47:43]

updated; please take another look?

[nodir, 2015-05-29 21:38:24]

lgtm

https://codereview.chromium.org/1143393004/diff/20001/doc/source/user_guide/b...
File doc/source/user_guide/builders_pyl.rst (right):

https://codereview.chromium.org/1143393004/diff/20001/doc/source/user_guide/b...
doc/source/user_guide/builders_pyl.rst:127: slave machine (i.e., just the
basename + suffix, no directory part), that
s/suffix/extension

[Dirk Pranke, 2015-05-29 21:49:19]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-05-29 21:49:19]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/1143393004/#ps40001
(title: "s/suffix/extension/")

[commit-bot: I haz the power, 2015-05-29 22:00:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143393004/40001

[commit-bot: I haz the power, 2015-05-29 22:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-29 22:06:57]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[Dirk Pranke, 2015-05-29 22:11:23]

Philippe, can I get an OWNERS approval for this?

[Dirk Pranke, 2015-05-29 22:11:42]

dpranke@chromium.org changed reviewers:
+ pgervais@chromium.org

[pgervais, 2015-05-29 23:38:53]

On 2015/05/29 22:11:23, Dirk Pranke wrote:
> Philippe, can I get an OWNERS approval for this?

lgtm, sorry for the long delay...

[pgervais, 2015-05-29 23:39:23]

The CQ bit was checked by pgervais@chromium.org

[commit-bot: I haz the power, 2015-05-29 23:39:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143393004/40001

[commit-bot: I haz the power, 2015-05-29 23:42:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/aa8e2e15f274784fef16133bbd158...