Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1143363006: Revert of Enable more benchmark_smoke_unittest coverage (Closed)

Created:
5 years, 7 months ago by battre
Modified:
5 years, 7 months ago
Reviewers:
sullivan, dtu, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable more benchmark_smoke_unittest coverage (patchset #4 id:100001 of https://codereview.chromium.org/1144193002/) Reason for revert: Reverting due to flaky perf tests (see crbug.com/490130 for details). Original issue's description: > Enable more benchmark_smoke_unittest coverage > > Previously, benchmark_smoke_unittest has a heuristic to pick > a benchmark for smoke testing if the benchmark uses a test > in measurement directory. > This patch removes that check, and instead provide a black > list of benchmarks module that we exclude the > benchmark_smoke_unittest to avoid high CQ time. > > This helped increases benchmark smoke coverage from 14 benchmarks -> 33 benchmarks (one in each benchmark module). > > On my local linux machine, this increases the cycle time of > benchmark_smoke_unittest from 20s -> 1m7s. > > BUG=490130 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/65014162e48a7f5881e8b282dd9e8dc17c5aa7c4 > Cr-Commit-Position: refs/heads/master@{#330909} TBR=sullivan@chromium.org,dtu@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490130 Committed: https://crrev.com/2d93642c4820e676dacf311d81a8e33aa2d1cc1d Cr-Commit-Position: refs/heads/master@{#330923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -27 lines) Patch
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 3 chunks +11 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
Created Revert of Enable more benchmark_smoke_unittest coverage
5 years, 7 months ago (2015-05-21 10:00:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143363006/1
5 years, 7 months ago (2015-05-21 10:00:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 10:01:27 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 10:02:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d93642c4820e676dacf311d81a8e33aa2d1cc1d
Cr-Commit-Position: refs/heads/master@{#330923}

Powered by Google App Engine
This is Rietveld 408576698