chrome/browser/printing/print_view_manager_base.cc - Issue 1143343005: chrome/browser: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager_base.cc

Issue 1143343005: chrome/browser: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_pdf_generated_browsertest.cc ('k') | chrome/browser/process_resource_usage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_view_manager_base.cc

diff --git a/chrome/browser/printing/print_view_manager_base.cc b/chrome/browser/printing/print_view_manager_base.cc

index edc5aa6deafb237f1771bda5f952d41bf8c04fb2..fc7720c6527760cac4372b32026b336a570324df 100644

--- a/chrome/browser/printing/print_view_manager_base.cc

+++ b/chrome/browser/printing/print_view_manager_base.cc

@@ -6,9 +6,12 @@

#include "base/auto_reset.h"

#include "base/bind.h"

+#include "base/location.h"

#include "base/memory/scoped_ptr.h"

#include "base/prefs/pref_service.h"

+#include "base/single_thread_task_runner.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/thread_task_runner_handle.h"

#include "base/timer/timer.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_notification_types.h"

@@ -208,7 +211,7 @@ void PrintViewManagerBase::OnPrintingFailed(int cookie) {

}

void PrintViewManagerBase::OnShowInvalidPrinterSettingsError() {

- base::MessageLoop::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, base::Bind(&ShowWarningMessageBox,

l10n_util::GetStringUTF16(

IDS_PRINT_INVALID_PRINTER_SETTINGS)));

« no previous file with comments | « chrome/browser/printing/print_preview_pdf_generated_browsertest.cc ('k') | chrome/browser/process_resource_usage.cc » ('j') | no next file with comments »