chrome/browser/devtools/devtools_targets_ui.cc - Issue 1143343005: chrome/browser: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 1143343005: chrome/browser: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_sanity_browsertest.cc ('k') | chrome/browser/download/chrome_download_manager_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_targets_ui.cc

diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc

index 498c5c3ee2d2d4154951019e05be120c7207a7d5..6dff4315116b6d56f5c55b41ff04bf1406184721 100644

--- a/chrome/browser/devtools/devtools_targets_ui.cc

+++ b/chrome/browser/devtools/devtools_targets_ui.cc

@@ -4,9 +4,12 @@

#include "chrome/browser/devtools/devtools_targets_ui.h"

+#include "base/location.h"

#include "base/memory/weak_ptr.h"

+#include "base/single_thread_task_runner.h"

#include "base/stl_util.h"

#include "base/strings/stringprintf.h"

+#include "base/thread_task_runner_handle.h"

#include "base/values.h"

#include "base/version.h"

#include "chrome/browser/devtools/device/devtools_android_bridge.h"

@@ -69,10 +72,9 @@ class CancelableTimer {

CancelableTimer(base::Closure callback, base::TimeDelta delay)

: callback_(callback),

weak_factory_(this) {

- base::MessageLoop::current()->PostDelayedTask(

+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

FROM_HERE,

- base::Bind(&CancelableTimer::Fire, weak_factory_.GetWeakPtr()),

- delay);

+ base::Bind(&CancelableTimer::Fire, weak_factory_.GetWeakPtr()), delay);

}

private: