Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Side by Side Diff: chrome/browser/metrics/first_web_contents_profiler.cc

Issue 1143343005: chrome/browser: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if !defined(OS_ANDROID) 5 #if !defined(OS_ANDROID)
6 6
7 #include "chrome/browser/metrics/first_web_contents_profiler.h" 7 #include "chrome/browser/metrics/first_web_contents_profiler.h"
8 8
9 #include "base/message_loop/message_loop.h" 9 #include "base/location.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
11 #include "base/process/process_info.h" 11 #include "base/process/process_info.h"
12 #include "base/single_thread_task_runner.h"
13 #include "base/thread_task_runner_handle.h"
12 #include "base/time/time.h" 14 #include "base/time/time.h"
13 #include "chrome/browser/ui/browser.h" 15 #include "chrome/browser/ui/browser.h"
14 #include "chrome/browser/ui/browser_iterator.h" 16 #include "chrome/browser/ui/browser_iterator.h"
15 #include "chrome/browser/ui/tabs/tab_strip_model.h" 17 #include "chrome/browser/ui/tabs/tab_strip_model.h"
16 #include "components/metrics/profiler/tracking_synchronizer.h" 18 #include "components/metrics/profiler/tracking_synchronizer.h"
17 #include "components/metrics/proto/profiler_event.pb.h" 19 #include "components/metrics/proto/profiler_event.pb.h"
18 #include "content/public/browser/browser_thread.h" 20 #include "content/public/browser/browser_thread.h"
19 21
20 namespace { 22 namespace {
21 // The initial delay for responsiveness prober in milliseconds. 23 // The initial delay for responsiveness prober in milliseconds.
(...skipping 25 matching lines...) Expand all
47 base::Time now = base::Time::Now(); 49 base::Time now = base::Time::Now();
48 base::TimeDelta elapsed = now - task_posted_time; 50 base::TimeDelta elapsed = now - task_posted_time;
49 51
50 // Task executed in less then 1/60s. 52 // Task executed in less then 1/60s.
51 if (elapsed.InMilliseconds() <= (1000 / 60)) { 53 if (elapsed.InMilliseconds() <= (1000 / 60)) {
52 responsiveness_histogram->AddTime(now - start_recording_time); 54 responsiveness_histogram->AddTime(now - start_recording_time);
53 } else if (next_task_delay.InMilliseconds() > kMaxDelayMs) { 55 } else if (next_task_delay.InMilliseconds() > kMaxDelayMs) {
54 // Records elapsed time to execute last task. 56 // Records elapsed time to execute last task.
55 unresponsiveness_histogram->AddTime(elapsed); 57 unresponsiveness_histogram->AddTime(elapsed);
56 } else { 58 } else {
57 base::MessageLoop::current()->PostDelayedTask( 59 base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
58 FROM_HERE, 60 FROM_HERE,
59 base::Bind(&DelayedRecordUIResponsiveness, responsiveness_histogram, 61 base::Bind(&DelayedRecordUIResponsiveness, responsiveness_histogram,
60 unresponsiveness_histogram, start_recording_time, 62 unresponsiveness_histogram, start_recording_time,
61 next_task_delay * kBackoffMultiplier), 63 next_task_delay * kBackoffMultiplier),
62 next_task_delay); 64 next_task_delay);
63 } 65 }
64 } 66 }
65 67
66 // Used for posting |RecordUIResponsiveness| without delay, so that 68 // Used for posting |RecordUIResponsiveness| without delay, so that
67 // |RecordUIResponsiveness| can do more accurate time calculation for elapsed 69 // |RecordUIResponsiveness| can do more accurate time calculation for elapsed
68 // time of the task to complete. 70 // time of the task to complete.
69 void DelayedRecordUIResponsiveness( 71 void DelayedRecordUIResponsiveness(
70 base::HistogramBase* responsiveness_histogram, 72 base::HistogramBase* responsiveness_histogram,
71 base::HistogramBase* unresponsiveness_histogram, 73 base::HistogramBase* unresponsiveness_histogram,
72 base::Time start_recording_time, 74 base::Time start_recording_time,
73 base::TimeDelta next_task_delay) { 75 base::TimeDelta next_task_delay) {
74 base::MessageLoop::current()->PostTask( 76 base::ThreadTaskRunnerHandle::Get()->PostTask(
75 FROM_HERE, base::Bind(&RecordUIResponsiveness, responsiveness_histogram, 77 FROM_HERE, base::Bind(&RecordUIResponsiveness, responsiveness_histogram,
76 unresponsiveness_histogram, start_recording_time, 78 unresponsiveness_histogram, start_recording_time,
77 base::Time::Now(), next_task_delay)); 79 base::Time::Now(), next_task_delay));
78 } 80 }
79 81
80 // Sends the first task for measuring UI Responsiveness. 82 // Sends the first task for measuring UI Responsiveness.
81 void MeasureUIResponsiveness(base::HistogramBase* responsiveness_histogram, 83 void MeasureUIResponsiveness(base::HistogramBase* responsiveness_histogram,
82 base::HistogramBase* unresponsiveness_histogram) { 84 base::HistogramBase* unresponsiveness_histogram) {
83 base::MessageLoop::current()->PostTask( 85 base::ThreadTaskRunnerHandle::Get()->PostTask(
84 FROM_HERE, 86 FROM_HERE,
85 base::Bind(&RecordUIResponsiveness, responsiveness_histogram, 87 base::Bind(&RecordUIResponsiveness, responsiveness_histogram,
86 unresponsiveness_histogram, base::Time::Now(), 88 unresponsiveness_histogram, base::Time::Now(),
87 base::Time::Now(), 89 base::Time::Now(),
88 base::TimeDelta::FromMilliseconds(kInitialDelayMs))); 90 base::TimeDelta::FromMilliseconds(kInitialDelayMs)));
89 } 91 }
90 92
91 } // namespace 93 } // namespace
92 94
93 scoped_ptr<FirstWebContentsProfiler> 95 scoped_ptr<FirstWebContentsProfiler>
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 metrics::ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT); 141 metrics::ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT);
140 142
141 // Measures responsiveness now. 143 // Measures responsiveness now.
142 MeasureUIResponsiveness(responsiveness_histogram_, 144 MeasureUIResponsiveness(responsiveness_histogram_,
143 unresponsiveness_histogram_); 145 unresponsiveness_histogram_);
144 146
145 // As it was observed that sometimes the task queue can be free immediately 147 // As it was observed that sometimes the task queue can be free immediately
146 // after the first paint but get overloaded shortly thereafter, here we 148 // after the first paint but get overloaded shortly thereafter, here we
147 // measures responsiveness after 1 second and 10 seconds to observe the 149 // measures responsiveness after 1 second and 10 seconds to observe the
148 // possible effect of those late tasks. 150 // possible effect of those late tasks.
149 base::MessageLoop::current()->PostDelayedTask( 151 base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
150 FROM_HERE, 152 FROM_HERE,
151 base::Bind(&MeasureUIResponsiveness, responsiveness_1sec_histogram_, 153 base::Bind(&MeasureUIResponsiveness, responsiveness_1sec_histogram_,
152 unresponsiveness_1sec_histogram_), 154 unresponsiveness_1sec_histogram_),
153 base::TimeDelta::FromSeconds(1)); 155 base::TimeDelta::FromSeconds(1));
154 156
155 base::MessageLoop::current()->PostDelayedTask( 157 base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
156 FROM_HERE, 158 FROM_HERE,
157 base::Bind(&MeasureUIResponsiveness, responsiveness_10sec_histogram_, 159 base::Bind(&MeasureUIResponsiveness, responsiveness_10sec_histogram_,
158 unresponsiveness_10sec_histogram_), 160 unresponsiveness_10sec_histogram_),
159 base::TimeDelta::FromSeconds(10)); 161 base::TimeDelta::FromSeconds(10));
160 162
161 if (IsFinishedCollectingMetrics()) 163 if (IsFinishedCollectingMetrics())
162 FinishedCollectingMetrics(); 164 FinishedCollectingMetrics();
163 } 165 }
164 166
165 void FirstWebContentsProfiler::DocumentOnLoadCompletedInMainFrame() { 167 void FirstWebContentsProfiler::DocumentOnLoadCompletedInMainFrame() {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 100, base::Histogram::kUmaTargetedHistogramFlag); 229 100, base::Histogram::kUmaTargetedHistogramFlag);
228 230
229 const std::string unresponsiveness_10sec_histogram_name = 231 const std::string unresponsiveness_10sec_histogram_name =
230 "Startup.FirstWebContents.UINotResponsive_10sec"; 232 "Startup.FirstWebContents.UINotResponsive_10sec";
231 unresponsiveness_10sec_histogram_ = base::Histogram::FactoryTimeGet( 233 unresponsiveness_10sec_histogram_ = base::Histogram::FactoryTimeGet(
232 unresponsiveness_10sec_histogram_name, 234 unresponsiveness_10sec_histogram_name,
233 base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromSeconds(60), 235 base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromSeconds(60),
234 100, base::Histogram::kUmaTargetedHistogramFlag); 236 100, base::Histogram::kUmaTargetedHistogramFlag);
235 } 237 }
236 #endif // !defined(OS_ANDROID) 238 #endif // !defined(OS_ANDROID)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698