Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1143343004: Rationalise hit testing in the new RenderNode world (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rationalise hit testing in the new RenderNode world - makes the event logic not involve a boolean return value (since we ignored it anyway) - splits the event handling logic into two steps, hit testing and event dispatch - introduces an App class on the Dart side to factor out the interaction with the C++ side - ports sector-layout and simple_render_tree to the new App infrastructure - port simple_render_tree to the new event handling logic - implement hit testing for the sector-layout demo R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a865f73d9c1044e223776c0c8c4abf6be11b5e48

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -137 lines) Patch
M sky/engine/core/view/EventCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/view/EventCallback.idl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/view/View.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/view/View.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/engine/public/sky/sky_view.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/sky/sky_view.cc View 1 chunk +8 lines, -15 lines 0 comments Download
M sky/examples/raw/sector-layout.dart View 9 chunks +65 lines, -34 lines 0 comments Download
M sky/examples/raw/simple_render_tree.dart View 3 chunks +6 lines, -30 lines 0 comments Download
M sky/examples/raw/touch_demo.dart View 4 chunks +4 lines, -21 lines 0 comments Download
M sky/sdk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A sky/sdk/lib/framework/app.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/layout2.dart View 9 chunks +64 lines, -31 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
eseidel
lgtm https://codereview.chromium.org/1143343004/diff/1/sky/sdk/lib/framework/layout2.dart File sky/sdk/lib/framework/layout2.dart (right): https://codereview.chromium.org/1143343004/diff/1/sky/sdk/lib/framework/layout2.dart#newcode495 sky/sdk/lib/framework/layout2.dart:495: if (x < 0.0 || x >= width ...
5 years, 7 months ago (2015-05-26 19:38:23 UTC) #2
Hixie
Committed patchset #1 (id:1) manually as a865f73d9c1044e223776c0c8c4abf6be11b5e48 (presubmit successful).
5 years, 7 months ago (2015-05-26 19:44:39 UTC) #3
Hixie
5 years, 7 months ago (2015-05-26 19:44:52 UTC) #4
Message was sent while issue was closed.
> sky/sdk/lib/framework/layout2.dart:495: if (x < 0.0 || x >= width || y < 0.0
|| y >= height)
> If we had a Rect class it could abstract this away.  rect.contains(point).

https://github.com/domokit/mojo/issues/177

Powered by Google App Engine
This is Rietveld 408576698