extensions/browser/api/web_request/web_request_api.cc - Issue 1143333008: Getting rid of more webview memory leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 1143333008: Getting rid of more webview memory leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/web_request/web_request_api.cc

diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc

index f6c75274dca5baff22e2f25a09487a06a1055474..836cae30b30b683eaae41e98c64a865e55511a81 100644

--- a/extensions/browser/api/web_request/web_request_api.cc

+++ b/extensions/browser/api/web_request/web_request_api.cc

@@ -1346,7 +1346,6 @@ void ExtensionWebRequestEventRouter::RemoveEventListener(

void ExtensionWebRequestEventRouter::RemoveWebViewEventListeners(

void* browser_context,

- const std::string& extension_id,

int embedder_process_id,

int web_view_instance_id) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

@@ -1370,7 +1369,7 @@ void ExtensionWebRequestEventRouter::RemoveWebViewEventListeners(

for (const auto& listener : listeners_to_delete) {

RemoveEventListenerOnIOThread(

browser_context,

- extension_id,

+ listener.extension_id,

listener.sub_event_name,

listener.embedder_process_id,

listener.web_view_instance_id);