extensions/renderer/resources/guest_view/guest_view_container.js - Issue 1143333008: Getting rid of more webview memory leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/guest_view_container.js

Issue 1143333008: Getting rid of more webview memory leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/guest_view/guest_view_container.js

diff --git a/extensions/renderer/resources/guest_view/guest_view_container.js b/extensions/renderer/resources/guest_view/guest_view_container.js

index ebcc3136b5e56a3b0bb67996f3da111ab60ebb61..21c92f2207cbb9edafafeba14b3d42b42b243a93 100644

--- a/extensions/renderer/resources/guest_view/guest_view_container.js

+++ b/extensions/renderer/resources/guest_view/guest_view_container.js

@@ -27,7 +27,7 @@ function GuestViewContainer(element, viewType) {

var shadowRoot = this.element.createShadowRoot();

shadowRoot.appendChild(privates(this).browserPluginElement);

- GuestViewInternalNatives.RegisterView(this.viewInstanceId, this);

+ GuestViewInternalNatives.RegisterView(this.viewInstanceId, this, viewType);

}

// Forward public API methods from |proto| to their internal implementations.