components/guest_view/browser/test_guest_view_manager.cc - Issue 1143333008: Getting rid of more webview memory leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/test_guest_view_manager.cc

Issue 1143333008: Getting rid of more webview memory leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/guest_view/browser/test_guest_view_manager.cc

diff --git a/components/guest_view/browser/test_guest_view_manager.cc b/components/guest_view/browser/test_guest_view_manager.cc

index 584d0fcffea750b30ce027542652efe3872ab1f3..4f04d65659f799f5a037db0859b2954588ee36de 100644

--- a/components/guest_view/browser/test_guest_view_manager.cc

+++ b/components/guest_view/browser/test_guest_view_manager.cc

@@ -91,6 +91,7 @@ void TestGuestViewManager::RemoveGuest(int guest_instance_id) {

void TestGuestViewManager::ViewGarbageCollected(int embedder_process_id,

int view_instance_id) {

+ GuestViewManager::ViewGarbageCollected(embedder_process_id, view_instance_id);

++num_views_garbage_collected_;

if (gc_message_loop_runner_.get())

gc_message_loop_runner_->Quit();