Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: Source/core/layout/LayoutCounter.h

Issue 1143323011: Notify the counter code about layout object removals BEFORE removing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 2 * Copyright (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
3 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 19 matching lines...) Expand all
30 class CounterNode; 30 class CounterNode;
31 31
32 class LayoutCounter final : public LayoutText { 32 class LayoutCounter final : public LayoutText {
33 public: 33 public:
34 LayoutCounter(Document*, const CounterContent&); 34 LayoutCounter(Document*, const CounterContent&);
35 virtual ~LayoutCounter(); 35 virtual ~LayoutCounter();
36 36
37 static void destroyCounterNodes(LayoutObject&); 37 static void destroyCounterNodes(LayoutObject&);
38 static void destroyCounterNode(LayoutObject&, const AtomicString& identifier ); 38 static void destroyCounterNode(LayoutObject&, const AtomicString& identifier );
39 static void layoutObjectSubtreeAttached(LayoutObject*); 39 static void layoutObjectSubtreeAttached(LayoutObject*);
40 static void layoutObjectRemovedFromTree(LayoutObject*); 40 static void layoutObjectSubtreeWillBeDetached(LayoutObject*);
41 static void layoutObjectStyleChanged(LayoutObject&, const ComputedStyle* old Style, const ComputedStyle& newStyle); 41 static void layoutObjectStyleChanged(LayoutObject&, const ComputedStyle* old Style, const ComputedStyle& newStyle);
42 42
43 void updateCounter(); 43 void updateCounter();
44 44
45 virtual const char* name() const override { return "LayoutCounter"; } 45 virtual const char* name() const override { return "LayoutCounter"; }
46 46
47 protected: 47 protected:
48 virtual void willBeDestroyed() override; 48 virtual void willBeDestroyed() override;
49 49
50 private: 50 private:
(...skipping 13 matching lines...) Expand all
64 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutCounter, isCounter()); 64 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutCounter, isCounter());
65 65
66 } // namespace blink 66 } // namespace blink
67 67
68 #ifndef NDEBUG 68 #ifndef NDEBUG
69 // Outside the WebCore namespace for ease of invocation from gdb. 69 // Outside the WebCore namespace for ease of invocation from gdb.
70 void showCounterLayoutTree(const blink::LayoutObject*, const char* counterName = 0); 70 void showCounterLayoutTree(const blink::LayoutObject*, const char* counterName = 0);
71 #endif 71 #endif
72 72
73 #endif // LayoutCounter_h 73 #endif // LayoutCounter_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/css/counters/remove-anonymous-block-wrapper-crash-expected.txt ('k') | Source/core/layout/LayoutCounter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698