Refactor Nacl to remove assumptions about SharedMemoryHandle.

components/nacl/browser/nacl_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/browser/nacl_process_host.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 928 matching lines @@
     // mappable with PROT_EXEC.  Rather than requiring an extra IPC
     // round trip out of the sandbox, we create an FD here.
     base::SharedMemory memory_buffer;
     base::SharedMemoryCreateOptions options;
     options.size = 1;
     options.executable = true;
     if (!memory_buffer.Create(options)) {
       DLOG(ERROR) << "Failed to allocate memory buffer";
       return false;
     }
-    base::ScopedFD memory_fd(dup(memory_buffer.handle().fd));
+    base::SharedMemoryHandle duped_handle =
+        base::SharedMemory::DuplicateHandle(memory_buffer.handle());
+    base::ScopedFD memory_fd(
+        base::SharedMemory::GetFdFromSharedMemoryHandle(duped_handle));

[Mark Seaborn, 2015/06/04 20:17:55]

How will this help you switch to having SharedMemoryHandle be a Mach port on Mac
OS X?  This code is still assuming that you can convert a SharedMemoryHandle to
an FD.  Will it be possible to convert a Mach port to an FD?

Have you got follow-on changes prepared which do that?

[erikchen, 2015/06/04 20:25:42]

I have a CL that changes SharedMemoryHandle to be a class on OSX, which is a
necessary first step to making SharedMemoryHandle backed by Mach primitives. 

https://codereview.chromium.org/1163943004/

Before I can make SharedMemoryHandle a class, I need to update all existing
references to SharedMemoryHandle that assume that SharedMemoryHandle is
typedefed to FileDescriptor. This is one of those locations.

If your curious, my next high level steps are:
1) Make SharedMemoryHandle a class that wraps POSIX fd.
2) Make SharedMemoryHandle support both POSIX fd and Mach primitives.
3) Migrate consumers of base::SharedMemory to use Mach primitives.

[Mark Seaborn, 2015/06/04 20:45:01]

Which cases will require you to support storing an FD in SharedMemoryHandle on
Mac?  Do you intend to support that indefinitely?  Is it only NaCl that requires
this, or are there other cases?

Presumably you would change base::SharedMemory::Create() so that the caller can
specify whether to create an FD or a Mach port?

     if (!memory_fd.is_valid()) {
       DLOG(ERROR) << "Failed to dup() a file descriptor";
       return false;
     }
     params.mac_shm_fd = IPC::GetFileHandleForProcess(
         memory_fd.release(), data.handle, true);
 #endif
 
 #if defined(OS_POSIX)
     if (params.enable_debug_stub) {
@@ skipping 425 matching lines @@
     NaClStartDebugExceptionHandlerThread(
         process.Pass(), info, base::ThreadTaskRunnerHandle::Get(),
         base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
                    weak_factory_.GetWeakPtr()));
     return true;
   }
 }
 #endif
 
 }  // namespace nacl