Report new screen position to renderer when ancestor window moves.

content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_vector.h"
 #include "base/memory/shared_memory.h"
@@ skipping 788 matching lines @@
 
   // Verify that setting the size does not alter the origin.
   gfx::Point original_origin = window->bounds().origin();
   view_->SetSize(gfx::Size(120, 120));
   gfx::Point new_origin = window->bounds().origin();
   EXPECT_EQ(original_origin.ToString(), new_origin.ToString());
 
   aura::client::SetScreenPositionClient(root, NULL);
 }
 
+// Checks that moving parent sends new screen bounds.
+TEST_F(RenderWidgetHostViewAuraTest, ParentMovementUpdatesScreenRect) {
+  view_->InitAsChild(NULL);
+
+  aura::Window* root = parent_view_->GetNativeView()->GetRootWindow();
+
+  aura::test::TestWindowDelegate delegate1, delegate2;
+  scoped_ptr<aura::Window> parent2(new aura::Window(&delegate2));
+  parent2->Init(ui::LAYER_TEXTURED);
+  parent2->Show();
+  scoped_ptr<aura::Window> parent1(new aura::Window(&delegate1));
+  parent1->Init(ui::LAYER_TEXTURED);
+  parent1->Show();
+
+  root->AddChild(parent1.get());
+  parent1->AddChild(parent2.get());
+  parent2->AddChild(view_->GetNativeView());
+
+  root->SetBounds(gfx::Rect(0, 0, 400, 400));
+  parent1->SetBounds(gfx::Rect(1, 1, 300, 300));
+  parent2->SetBounds(gfx::Rect(2, 2, 200, 200));
+  view_->SetBounds(gfx::Rect(3, 3, 100, 100));
+
+  // Flush the state after initial setup is done.
+  widget_host_->OnMessageReceived(
+      ViewHostMsg_UpdateScreenRects_ACK(widget_host_->GetRoutingID()));
+  widget_host_->OnMessageReceived(
+      ViewHostMsg_UpdateScreenRects_ACK(widget_host_->GetRoutingID()));
+  sink_->ClearMessages();
+
+  // Move parents.
+  parent2->SetBounds(gfx::Rect(20, 20, 200, 200));
+  EXPECT_EQ(1U, sink_->message_count());

[sadrul, 2015/06/03 18:51:41]

Do an ASSERT_EQ here instead, and remove the conditional below in line 844.

[mharanczyk, 2015/06/08 11:56:31]

Done.

[mharanczyk, 2015/06/08 11:56:31]

Done.

+  const IPC::Message* msg = NULL;
+  ViewMsg_UpdateScreenRects::Param params;
+  if (sink_->message_count() == 1U) {
+    const IPC::Message* msg = sink_->GetMessageAt(0);
+    ViewMsg_UpdateScreenRects::Read(msg, &params);
+    EXPECT_EQ(ViewMsg_UpdateScreenRects::ID, msg->type());
+    EXPECT_EQ(gfx::Rect(24, 24, 100, 100), get<0>(params));

[sadrul, 2015/06/03 18:51:41]

base::get<>? (everywhere else in this test too)

[mharanczyk, 2015/06/08 11:56:31]

get is not defined in any namespace.

[mharanczyk, 2015/06/08 11:56:31]

get<> is placed outside of base namespace in base/tuple.h.

+    EXPECT_EQ(gfx::Rect(1, 1, 300, 300), get<1>(params));
+  }
+  sink_->ClearMessages();
+  widget_host_->OnMessageReceived(
+      ViewHostMsg_UpdateScreenRects_ACK(widget_host_->GetRoutingID()));
+  // There should not be any pending update.
+  EXPECT_EQ(0U, sink_->message_count());
+
+  parent1->SetBounds(gfx::Rect(10, 10, 300, 300));
+  EXPECT_EQ(1U, sink_->message_count());

[sadrul, 2015/06/03 18:51:41]

ditto

[mharanczyk, 2015/06/08 11:56:31]

Done.

[mharanczyk, 2015/06/08 11:56:31]

Done.

+  if (sink_->message_count() == 1U) {
+    msg = sink_->GetMessageAt(0);
+    ViewMsg_UpdateScreenRects::Read(msg, &params);
+    EXPECT_EQ(ViewMsg_UpdateScreenRects::ID, msg->type());
+    EXPECT_EQ(gfx::Rect(33, 33, 100, 100), get<0>(params));
+    EXPECT_EQ(gfx::Rect(10, 10, 300, 300), get<1>(params));
+  }
+  sink_->ClearMessages();
+  widget_host_->OnMessageReceived(
+      ViewHostMsg_UpdateScreenRects_ACK(widget_host_->GetRoutingID()));
+  // There should not be any pending update.
+  EXPECT_EQ(0U, sink_->message_count());
+
+  parent2->RemoveChild(view_->GetNativeView());
+  parent1->RemoveChild(parent2.get());
+  root->RemoveChild(parent1.get());
+}
+
 // Checks that a fullscreen view is destroyed when it loses the focus.
 TEST_F(RenderWidgetHostViewAuraTest, DestroyFullscreenOnBlur) {
   view_->InitAsFullscreen(parent_view_);
   aura::Window* window = view_->GetNativeView();
   ASSERT_TRUE(window != NULL);
   ASSERT_TRUE(window->HasFocus());
 
   // After we create and focus another window, the RWHVA's window should be
   // destroyed.
   TestWindowObserver observer(window);
@@ skipping 2678 matching lines @@
   ViewMsg_SetSurfaceIdNamespace::Read(msg, &params);
   view_->InitAsChild(NULL);
   view_->Show();
   view_->SetSize(size);
   view_->OnSwapCompositorFrame(0,
                                MakeDelegatedFrame(1.f, size, gfx::Rect(size)));
   EXPECT_EQ(view_->GetSurfaceIdNamespace(), get<0>(params));
 }
 
 }  // namespace content