components/nacl/browser/bad_message.h - Issue 1143323006: Histograms.xml python script housekeeping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/bad_message.h

Issue 1143323006: Histograms.xml python script housekeeping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bad_message

Patch Set: Split off the extensions permission weirdness. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/browser/bad_message.h

diff --git a/components/nacl/browser/bad_message.h b/components/nacl/browser/bad_message.h

index d8a0884a5861c3d78702251488c3c64e725e337f..297b7669563f2fb9460ff397f8e80b2b51ff41ed 100644

--- a/components/nacl/browser/bad_message.h

+++ b/components/nacl/browser/bad_message.h

@@ -19,7 +19,9 @@ namespace bad_message {

// NOTE: Do not remove or reorder elements in this list. Add new entries at the

// end. Items may be renamed but do not change the values. We rely on the enum

-// values in histograms. Also update histograms.xml with any new values.

+// values in histograms. Also update histograms.xml with any new values by

+// running:

+// python tools/metrics/histograms/update_bad_message_reasons.py

enum BadMessageReason {

NACL_OPEN_EXECUTABLE_BAD_ROUTING_ID = 0,

NACL_LAUNCH_CONTINUATION_BAD_ROUTING_ID = 1,