tools/metrics/histograms/histograms_path.py - Issue 1143323006: Histograms.xml python script housekeeping

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/metrics/histograms/histograms_path.py

Issue 1143323006: Histograms.xml python script housekeeping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bad_message

Patch Set: Split off the extensions permission weirdness. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/metrics/histograms/histograms.xml ('k') | tools/metrics/histograms/update_bad_message_reasons.py » ('j') | tools/metrics/histograms/update_editor_commands.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2013 The Chromium Authors. All rights reserved.
	Ilya Sherman 2015/05/27 00:12:24 nit: 2015 nit: 2015 ncarter (slow) 2015/05/29 23:01:10 Done. Show quoted text On 2015/05/27 00:12:24, Ilya Sherman wrote: > nit: 2015 Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """Utility functions for resolving file paths in histograms scripts."""

	6

	7 import os.path

	8

	9

	10 def GetHistogramsFile():

	11 """Returns the path to histograms.xml.

	12

	13 Prefer using this function instead of just open("histograms.xml"), so that

	14 scripts work properly even if run from outside the histograms directory.

	15 """

	16 return os.path.join(os.path.dirname(__file__), 'histograms.xml')

	17

	18

	19 def GetInputFile(src_relative_file_path):
	Ilya Sherman 2015/05/27 00:12:24 Is it worth providing this at a higher level, so t Is it worth providing this at a higher level, so that the actions and rappor scripts can also be cleaned up to use this? ncarter (slow) 2015/05/29 23:01:10 I moved it to common (as path_util.py). I also add Show quoted text On 2015/05/27 00:12:24, Ilya Sherman wrote: > Is it worth providing this at a higher level, so that the actions and rappor > scripts can also be cleaned up to use this? I moved it to common (as path_util.py). I also added __init__.py files to both common and histograms, so that the import statements give a little more of a hint where these files are coming from.
	20 """Converts a src/-relative file path into a path that can be opened."""

	21 depth = [os.path.dirname(__file__), '..', '..', '..']

	22 return os.path.join(*(depth + src_relative_file_path.split('/')))
	Ilya Sherman 2015/05/27 00:12:24 Out of curiousity, what does the "" operator do? Out of curiousity, what does the "" operator do? ncarter (slow) 2015/05/29 23:01:10 https://docs.python.org/2/tutorial/controlflow.htm Show quoted text On 2015/05/27 00:12:24, Ilya Sherman wrote: > Out of curiousity, what does the "" operator do? https://docs.python.org/2/tutorial/controlflow.html#unpacking-argument-lists Basically, the join() function accepts a variable number of positional arguments, but here we have a list of strings to be joined. "" lets you unpack the list so that each list element is passed an argument.
OLD	NEW