Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Side by Side Diff: components/nacl/browser/bad_message.h

Issue 1143323006: Histograms.xml python script housekeeping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bad_message
Patch Set: Fix imports (sadface) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/bad_message.h ('k') | content/browser/bad_message.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NACL_BROWSER_BAD_MESSAGE_H_ 5 #ifndef COMPONENTS_NACL_BROWSER_BAD_MESSAGE_H_
6 #define COMPONENTS_NACL_BROWSER_BAD_MESSAGE_H_ 6 #define COMPONENTS_NACL_BROWSER_BAD_MESSAGE_H_
7 7
8 namespace content { 8 namespace content {
9 class BrowserMessageFilter; 9 class BrowserMessageFilter;
10 } 10 }
11 11
12 namespace nacl { 12 namespace nacl {
13 namespace bad_message { 13 namespace bad_message {
14 14
15 // The browser process often chooses to terminate a renderer if it receives 15 // The browser process often chooses to terminate a renderer if it receives
16 // a bad IPC message. The reasons are tracked for metrics. 16 // a bad IPC message. The reasons are tracked for metrics.
17 // 17 //
18 // See also content/browser/bad_message.h. 18 // See also content/browser/bad_message.h.
19 // 19 //
20 // NOTE: Do not remove or reorder elements in this list. Add new entries at the 20 // NOTE: Do not remove or reorder elements in this list. Add new entries at the
21 // end. Items may be renamed but do not change the values. We rely on the enum 21 // end. Items may be renamed but do not change the values. We rely on the enum
22 // values in histograms. Also update histograms.xml with any new values. 22 // values in histograms. Also update histograms.xml with any new values by
23 // running:
24 // python tools/metrics/histograms/update_bad_message_reasons.py
23 enum BadMessageReason { 25 enum BadMessageReason {
24 NFH_OPEN_EXECUTABLE_BAD_ROUTING_ID = 0, 26 NFH_OPEN_EXECUTABLE_BAD_ROUTING_ID = 0,
25 NHMF_LAUNCH_CONTINUATION_BAD_ROUTING_ID = 1, 27 NHMF_LAUNCH_CONTINUATION_BAD_ROUTING_ID = 1,
26 NHMF_GET_NEXE_FD_BAD_URL = 2, 28 NHMF_GET_NEXE_FD_BAD_URL = 2,
27 29
28 // Please add new elements here. The naming convention is abbreviated class 30 // Please add new elements here. The naming convention is abbreviated class
29 // name (e.g. NaclHostMessageFilter becomes NHMF) plus a unique description of 31 // name (e.g. NaclHostMessageFilter becomes NHMF) plus a unique description of
30 // the reason. 32 // the reason.
31 BAD_MESSAGE_MAX 33 BAD_MESSAGE_MAX
32 }; 34 };
33 35
34 // Called when a browser message filter receives a bad IPC message from a 36 // Called when a browser message filter receives a bad IPC message from a
35 // renderer or other child process. Logs the event, records a histogram metric 37 // renderer or other child process. Logs the event, records a histogram metric
36 // for the |reason|, and terminates the process for |filter|. 38 // for the |reason|, and terminates the process for |filter|.
37 void ReceivedBadMessage(content::BrowserMessageFilter* filter, 39 void ReceivedBadMessage(content::BrowserMessageFilter* filter,
38 BadMessageReason reason); 40 BadMessageReason reason);
39 41
40 } // namespace bad_message 42 } // namespace bad_message
41 } // namespace nacl 43 } // namespace nacl
42 44
43 #endif // COMPONENTS_NACL_BROWSER_BAD_MESSAGE_H_ 45 #endif // COMPONENTS_NACL_BROWSER_BAD_MESSAGE_H_
OLDNEW
« no previous file with comments | « chrome/browser/bad_message.h ('k') | content/browser/bad_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698