Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: chrome/browser/bad_message.h

Issue 1143323006: Histograms.xml python script housekeeping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bad_message
Patch Set: Fix imports (sadface) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/nacl/browser/bad_message.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BAD_MESSAGE_H_ 5 #ifndef CHROME_BROWSER_BAD_MESSAGE_H_
6 #define CHROME_BROWSER_BAD_MESSAGE_H_ 6 #define CHROME_BROWSER_BAD_MESSAGE_H_
7 7
8 namespace content { 8 namespace content {
9 class BrowserMessageFilter; 9 class BrowserMessageFilter;
10 class RenderProcessHost; 10 class RenderProcessHost;
11 } 11 }
12 12
13 namespace bad_message { 13 namespace bad_message {
14 14
15 // The browser process often chooses to terminate a renderer if it receives 15 // The browser process often chooses to terminate a renderer if it receives
16 // a bad IPC message. The reasons are tracked for metrics. 16 // a bad IPC message. The reasons are tracked for metrics.
17 // 17 //
18 // See also content/browser/bad_message.h. 18 // See also content/browser/bad_message.h.
19 // 19 //
20 // NOTE: Do not remove or reorder elements in this list. Add new entries at the 20 // NOTE: Do not remove or reorder elements in this list. Add new entries at the
21 // end. Items may be renamed but do not change the values. We rely on the enum 21 // end. Items may be renamed but do not change the values. We rely on the enum
22 // values in histograms. Also update histograms.xml with any new values. 22 // values in histograms. Also update histograms.xml with any new values by
23 // running:
24 // python tools/metrics/histograms/update_bad_message_reasons.py
23 enum BadMessageReason { 25 enum BadMessageReason {
24 WRLHH_LOGGING_STOPPED_BAD_STATE = 0, 26 WRLHH_LOGGING_STOPPED_BAD_STATE = 0,
25 27
26 // Please add new elements here. The naming convention is abbreviated class 28 // Please add new elements here. The naming convention is abbreviated class
27 // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the 29 // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the
28 // reason. 30 // reason.
29 BAD_MESSAGE_MAX 31 BAD_MESSAGE_MAX
30 }; 32 };
31 33
32 // Called when the browser receives a bad IPC message from a renderer process on 34 // Called when the browser receives a bad IPC message from a renderer process on
33 // the UI thread. Logs the event, records a histogram metric for the |reason|, 35 // the UI thread. Logs the event, records a histogram metric for the |reason|,
34 // and terminates the process for |host|. 36 // and terminates the process for |host|.
35 void ReceivedBadMessage(content::RenderProcessHost* host, 37 void ReceivedBadMessage(content::RenderProcessHost* host,
36 BadMessageReason reason); 38 BadMessageReason reason);
37 39
38 // Called when a browser message filter receives a bad IPC message from a 40 // Called when a browser message filter receives a bad IPC message from a
39 // renderer or other child process. Logs the event, records a histogram metric 41 // renderer or other child process. Logs the event, records a histogram metric
40 // for the |reason|, and terminates the process for |filter|. 42 // for the |reason|, and terminates the process for |filter|.
41 void ReceivedBadMessage(content::BrowserMessageFilter* filter, 43 void ReceivedBadMessage(content::BrowserMessageFilter* filter,
42 BadMessageReason reason); 44 BadMessageReason reason);
43 45
44 } // namespace bad_message 46 } // namespace bad_message
45 47
46 #endif // CHROME_BROWSER_BAD_MESSAGE_H_ 48 #endif // CHROME_BROWSER_BAD_MESSAGE_H_
OLDNEW
« no previous file with comments | « no previous file | components/nacl/browser/bad_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698