Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: google_apis/gaia/fake_oauth2_token_service.cc

Issue 1143323005: Refactor AO2TS to make it easier to componentize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor AO2TS to make it easier to componentize. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gaia/fake_oauth2_token_service.cc
diff --git a/google_apis/gaia/fake_oauth2_token_service.cc b/google_apis/gaia/fake_oauth2_token_service.cc
index adff32d321986d259f5ca8e6a361dcc80bf5a134..f425e789ff8d9b24c847b94a434f94d4f11cf4b0 100644
--- a/google_apis/gaia/fake_oauth2_token_service.cc
+++ b/google_apis/gaia/fake_oauth2_token_service.cc
@@ -10,7 +10,8 @@ FakeOAuth2TokenService::PendingRequest::PendingRequest() {
FakeOAuth2TokenService::PendingRequest::~PendingRequest() {
}
-FakeOAuth2TokenService::FakeOAuth2TokenService() : request_context_(NULL) {
+FakeOAuth2TokenService::FakeOAuth2TokenService() : OAuth2TokenService(NULL) {
+ request_context_ = nullptr;
}
FakeOAuth2TokenService::~FakeOAuth2TokenService() {
@@ -54,12 +55,12 @@ bool FakeOAuth2TokenService::RefreshTokenIsAvailable(
void FakeOAuth2TokenService::AddAccount(const std::string& account_id) {
account_ids_.insert(account_id);
- FireRefreshTokenAvailable(account_id);
+ // FireRefreshTokenAvailable(account_id);
}
void FakeOAuth2TokenService::RemoveAccount(const std::string& account_id) {
account_ids_.erase(account_id);
- FireRefreshTokenRevoked(account_id);
+ // FireRefreshTokenRevoked(account_id);
Roger Tawa OOO till Jul 10th 2015/05/24 21:13:18 We need a FakeOAuth2TokenServiceDelegate. I think
gogerald1 2015/05/25 21:10:57 Acknowledged. Definitely
}
void FakeOAuth2TokenService::IssueAllTokensForAccount(

Powered by Google App Engine
This is Rietveld 408576698