Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5468)

Unified Diff: chrome/browser/signin/fake_profile_oauth2_token_service.cc

Issue 1143323005: Refactor AO2TS to make it easier to componentize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor AO2TS to make it easier to componentize. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/fake_profile_oauth2_token_service.cc
diff --git a/chrome/browser/signin/fake_profile_oauth2_token_service.cc b/chrome/browser/signin/fake_profile_oauth2_token_service.cc
index 6901cdf4d890b840551abeee04f0f9545a0b46a0..16e7a2d48d358479fdd30dc6b5cc80850acd6954 100644
--- a/chrome/browser/signin/fake_profile_oauth2_token_service.cc
+++ b/chrome/browser/signin/fake_profile_oauth2_token_service.cc
@@ -14,7 +14,8 @@ FakeProfileOAuth2TokenService::PendingRequest::~PendingRequest() {
}
FakeProfileOAuth2TokenService::FakeProfileOAuth2TokenService()
- : auto_post_fetch_response_on_message_loop_(false),
+ : ProfileOAuth2TokenService(NULL),
+ auto_post_fetch_response_on_message_loop_(false),
weak_ptr_factory_(this) {
}
@@ -55,19 +56,19 @@ void FakeProfileOAuth2TokenService::IssueRefreshToken(
void FakeProfileOAuth2TokenService::IssueRefreshTokenForUser(
const std::string& account_id,
const std::string& token) {
- ScopedBatchChange batch(this);
+ // ScopedBatchChange batch(this);
if (token.empty()) {
refresh_tokens_.erase(account_id);
- FireRefreshTokenRevoked(account_id);
+ // FireRefreshTokenRevoked(account_id);
} else {
refresh_tokens_[account_id] = token;
- FireRefreshTokenAvailable(account_id);
+ // FireRefreshTokenAvailable(account_id);
// TODO(atwilson): Maybe we should also call FireRefreshTokensLoaded() here?
}
}
void FakeProfileOAuth2TokenService::IssueAllRefreshTokensLoaded() {
- FireRefreshTokensLoaded();
+ // FireRefreshTokensLoaded();
Roger Tawa OOO till Jul 10th 2015/05/24 21:13:18 Probably don't need this class anymore, once we ha
gogerald1 2015/05/25 21:10:57 Probably, need more investigation after we lock do
}
void FakeProfileOAuth2TokenService::IssueAllTokensForAccount(

Powered by Google App Engine
This is Rietveld 408576698