extensions/shell/browser/shell_oauth2_token_service_unittest.cc - Issue 1143323005: Refactor AO2TS to make it easier to componentize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_oauth2_token_service_unittest.cc

Issue 1143323005: Refactor AO2TS to make it easier to componentize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address final comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/browser/shell_oauth2_token_service_unittest.cc

diff --git a/extensions/shell/browser/shell_oauth2_token_service_unittest.cc b/extensions/shell/browser/shell_oauth2_token_service_unittest.cc

index 8b9dc72dad6dc6b6c26cd4ae787a29339b1bf246..649fd3abd54bc42f606bd1c753dd6ef2b7ad2ec0 100644

--- a/extensions/shell/browser/shell_oauth2_token_service_unittest.cc

+++ b/extensions/shell/browser/shell_oauth2_token_service_unittest.cc

@@ -23,14 +23,14 @@ TEST_F(ShellOAuth2TokenServiceTest, SetRefreshToken) {

ShellOAuth2TokenService service(nullptr, "larry@google.com", "token123");

// Only has a token for the account in the constructor.

- EXPECT_EQ("larry@google.com", service.account_id());

+ EXPECT_EQ("larry@google.com", service.AccountId());

EXPECT_TRUE(service.RefreshTokenIsAvailable("larry@google.com"));

EXPECT_FALSE(service.RefreshTokenIsAvailable("sergey@google.com"));

service.SetRefreshToken("sergey@google.com", "token456");

// The account and refresh token have updated.

- EXPECT_EQ("sergey@google.com", service.account_id());

+ EXPECT_EQ("sergey@google.com", service.AccountId());

EXPECT_FALSE(service.RefreshTokenIsAvailable("larry@google.com"));

EXPECT_TRUE(service.RefreshTokenIsAvailable("sergey@google.com"));

}