Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: components/signin/core/browser/profile_oauth2_token_service.cc

Issue 1143323005: Refactor AO2TS to make it easier to componentize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address final comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/profile_oauth2_token_service.cc
diff --git a/components/signin/core/browser/profile_oauth2_token_service.cc b/components/signin/core/browser/profile_oauth2_token_service.cc
index 0de1e2b6ded4e1848305cf2f9531007fce7b408d..e55c2cc992c72b938f3c479c68873be296e8e40b 100644
--- a/components/signin/core/browser/profile_oauth2_token_service.cc
+++ b/components/signin/core/browser/profile_oauth2_token_service.cc
@@ -4,74 +4,45 @@
#include "components/signin/core/browser/profile_oauth2_token_service.h"
-#include "base/bind.h"
-#include "base/message_loop/message_loop.h"
-#include "base/stl_util.h"
-#include "base/time/time.h"
-#include "components/signin/core/browser/signin_client.h"
-#include "components/signin/core/browser/signin_error_controller.h"
-#include "google_apis/gaia/gaia_auth_util.h"
-#include "net/url_request/url_request_context_getter.h"
-
-ProfileOAuth2TokenService::ProfileOAuth2TokenService()
- : client_(NULL),
- signin_error_controller_(NULL) {}
-
-ProfileOAuth2TokenService::~ProfileOAuth2TokenService() {}
-
-void ProfileOAuth2TokenService::Initialize(
- SigninClient* client,
- SigninErrorController* signin_error_controller) {
- DCHECK(client);
- DCHECK(!client_);
- DCHECK(signin_error_controller);
- DCHECK(!signin_error_controller_);
- client_ = client;
- signin_error_controller_ = signin_error_controller;
+void ProfileOAuth2TokenService::OnRefreshTokenAvailable(
+ const std::string& account_id) {
+ CancelRequestsForAccount(account_id);
+ ClearCacheForAccount(account_id);
}
-void ProfileOAuth2TokenService::Shutdown() {
- DCHECK(client_) << "Shutdown() called without matching call to Initialize()";
+void ProfileOAuth2TokenService::OnRefreshTokenRevoked(
+ const std::string& account_id) {
+ CancelRequestsForAccount(account_id);
+ ClearCacheForAccount(account_id);
}
-net::URLRequestContextGetter* ProfileOAuth2TokenService::GetRequestContext() {
- return NULL;
+ProfileOAuth2TokenService::ProfileOAuth2TokenService(
+ OAuth2TokenServiceDelegate* delegate)
+ : OAuth2TokenService(delegate) {
+ AddObserver(this);
}
-void ProfileOAuth2TokenService::UpdateAuthError(
- const std::string& account_id,
- const GoogleServiceAuthError& error) {
- NOTREACHED();
+ProfileOAuth2TokenService::~ProfileOAuth2TokenService() {
+ RemoveObserver(this);
}
-void ProfileOAuth2TokenService::ValidateAccountId(
- const std::string& account_id) const {
- DCHECK(!account_id.empty());
-
- // If the account is given as an email, make sure its a canonical email.
- // Note that some tests don't use email strings as account id, and after
- // the gaia id migration it won't be an email. So only check for
- // canonicalization if the account_id is suspected to be an email.
- if (account_id.find('@') != std::string::npos)
- DCHECK_EQ(gaia::CanonicalizeEmail(account_id), account_id);
-}
-
-std::vector<std::string> ProfileOAuth2TokenService::GetAccounts() {
- NOTREACHED();
- return std::vector<std::string>();
+void ProfileOAuth2TokenService::Shutdown() {
+ CancelAllRequests();
+ GetDelegate()->Shutdown();
}
void ProfileOAuth2TokenService::LoadCredentials(
const std::string& primary_account_id) {
- // Empty implementation by default.
+ GetDelegate()->LoadCredentials(primary_account_id);
}
void ProfileOAuth2TokenService::UpdateCredentials(
const std::string& account_id,
const std::string& refresh_token) {
- NOTREACHED();
+ GetDelegate()->UpdateCredentials(account_id, refresh_token);
}
-void ProfileOAuth2TokenService::RevokeAllCredentials() {
- // Empty implementation by default.
+void ProfileOAuth2TokenService::RevokeCredentials(
+ const std::string& account_id) {
+ GetDelegate()->RevokeCredentials(account_id);
}
« no previous file with comments | « components/signin/core/browser/profile_oauth2_token_service.h ('k') | components/signin/ios/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698