chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm - Issue 1143323005: Refactor AO2TS to make it easier to componentize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 1143323005: Refactor AO2TS to make it easier to componentize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address final comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

index 9e6140c56bd0574c99b76ad9cf288a8421765007..4afc575ab812b5afd3324fda999a3a68e7ae9708 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

@@ -48,7 +48,6 @@

#include "chrome/common/url_constants.h"

#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

-#include "components/signin/core/browser/mutable_profile_oauth2_token_service.h"

#include "components/signin/core/browser/profile_oauth2_token_service.h"

#include "components/signin/core/browser/signin_manager.h"

#include "components/signin/core/common/profile_management_switches.h"

@@ -1089,8 +1088,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,

- (IBAction)removeAccount:(id)sender {

DCHECK(!accountIdToRemove_.empty());

- ProfileOAuth2TokenServiceFactory::GetPlatformSpecificForProfile(

- browser_->profile())->RevokeCredentials(accountIdToRemove_);

+ ProfileOAuth2TokenServiceFactory::GetForProfile(browser_->profile())

+ ->RevokeCredentials(accountIdToRemove_);

[self postActionPerformed:ProfileMetrics::PROFILE_DESKTOP_MENU_REMOVE_ACCT];

accountIdToRemove_.clear();