Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(46)

Issue 1143323004: Oilpan: Validate pointers stored in CrossThreadPersistent (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, keishi
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Validate pointers stored in CrossThreadPersistent This CL adds checkPointer() to all pointer updates of CrossThreadPersistent. The checkPointer() verifies that the pointer is a pointer to an on-heap object. BUG=475801 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196384

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -14 lines) Patch
M Source/platform/heap/Handle.h View 1 2 3 6 chunks +54 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
haraken
PTAL
4 years, 11 months ago (2015-05-21 11:11:51 UTC) #2
keishi
lgtm
4 years, 11 months ago (2015-05-21 11:16:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143323004/1
4 years, 11 months ago (2015-05-21 11:16:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/62573)
4 years, 11 months ago (2015-05-21 13:46:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143323004/1
4 years, 11 months ago (2015-05-26 00:01:48 UTC) #9
haraken
I rewrote the checkPointer with Heap::isHeapObjectAlive(). Landing.
4 years, 11 months ago (2015-06-03 07:46:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143323004/60001
4 years, 11 months ago (2015-06-03 07:46:37 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 09:05:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196384

Powered by Google App Engine
This is Rietveld 408576698