Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1143313007: Apply vector-effect transform to path geometry - not stroke geometry (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Apply vector-effect transform to path geometry - not stroke geometry When drawing line caps for zero-length subpaths, the path-derived geometry is the position of the linecap, and not the generated shape. Hence the non-scaling-stroke transform should be applied to the position where the line cap shape should be drawn, and no the shape itself. This also means that we can simplify the code, by calling drawRect/Oval directly instead of going through a Path object. BUG=497498 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -13 lines) Patch
A LayoutTests/svg/stroke/non-scaling-stroke-zero-length-subpath-linecaps.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/svg/stroke/non-scaling-stroke-zero-length-subpath-linecaps-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/paint/SVGShapePainter.cpp View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 6 months ago (2015-06-08 14:57:18 UTC) #2
Stephen Chennney
lgtm. Good find.
5 years, 6 months ago (2015-06-08 15:04:57 UTC) #3
fs
On 2015/06/08 15:04:57, Stephen Chenney wrote: > lgtm. Good find. I think the reporter of ...
5 years, 6 months ago (2015-06-08 15:50:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143313007/1
5 years, 6 months ago (2015-06-08 15:50:58 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 16:37:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196684

Powered by Google App Engine
This is Rietveld 408576698