Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tool/input_sdk/private/js_number.dart

Issue 1143273002: Add types to shift operations (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart ('K') | « test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/private/js_number.dart
diff --git a/tool/input_sdk/private/js_number.dart b/tool/input_sdk/private/js_number.dart
index aac12e28baa1a61ea8c96b49267e7f2e5cb5e565..6bc999a4239d7f1593466a32c4441323f871b3fa 100644
--- a/tool/input_sdk/private/js_number.dart
+++ b/tool/input_sdk/private/js_number.dart
@@ -393,9 +393,9 @@ class JSInt extends JSNumber implements int, double {
return (i & 0x0000003F);
}
- static _shru(int value, int shift) => JS('int', '# >>> #', value, shift);
- static _shrs(int value, int shift) => JS('int', '# >> #', value, shift);
- static _ors(int a, int b) => JS('int', '# | #', a, b);
+ static int _shru(int value, int shift) => JS('int', '# >>> #', value, shift);
+ static int _shrs(int value, int shift) => JS('int', '# >> #', value, shift);
+ static int _ors(int a, int b) => JS('int', '# | #', a, b);
// Assumes i is <= 32-bit
static int _spread(int i) {
« test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart ('K') | « test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698