Issue 1143273002: Add types to shift operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1143273002: Add types to shift operations (Closed)

Created:
5 years, 7 months ago by vsm

Modified:
5 years, 7 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add types to shift operations Not sure why these weren't typed in the first place. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/7b698b3a533b8849851b397f730888a1eaf84504

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -19 lines)			Patch
M	lib/runtime/dart/_interceptors.js	View	3 chunks	+13 lines, -13 lines	0 comments	Download
M	test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	tool/input_sdk/private/js_number.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/1143273002/diff/1/test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart File test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart (right): https://codereview.chromium.org/1143273002/diff/1/test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart#newcode396 test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart:396: static int _shru(int value, int shift) => JS('int', ...

5 years, 7 months ago (2015-05-20 17:50:19 UTC) #3

vsm

5 years, 7 months ago (2015-05-22 16:08:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b698b3a533b8849851b397f730888a1eaf84504 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages