Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1143253012: More work on removing variants from Autofill (Closed)

Created:
5 years, 6 months ago by Evan Stade
Modified:
5 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, browser-components-watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More work on removing variants from Autofill This patch has some substantive changes that are not just code deletion, mainly around syncing/merging behavior. BUG=493856 TBR=zea@chromium.org Committed: https://crrev.com/431dfb72aedd23675487fc8df3ac927305fc494d Cr-Commit-Position: refs/heads/master@{#333155}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : try job #

Patch Set 4 : self review #

Total comments: 6

Patch Set 5 : rouslan review #

Patch Set 6 : fix test #

Patch Set 7 : work around iOS lameness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -484 lines) Patch
M chrome/browser/extensions/api/autofill_private/autofill_util.cc View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_profile.h View 1 2 3 4 4 chunks +14 lines, -13 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 2 3 4 12 chunks +86 lines, -151 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_unittest.cc View 1 2 3 chunks +6 lines, -147 lines 0 comments Download
M components/autofill/core/browser/contact_info.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/contact_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/data_driven_test.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 10 chunks +44 lines, -23 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_syncable_service.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc View 1 2 3 chunks +12 lines, -24 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc View 1 2 5 chunks +13 lines, -61 lines 0 comments Download
D components/test/data/autofill/merge/input/multimerge.in View 1 chunk +0 lines, -26 lines 0 comments Download
D components/test/data/autofill/merge/output/multimerge.out View 1 chunk +0 lines, -18 lines 0 comments Download
M components/test/data/autofill/merge/output/primarycase.out View 2 chunks +12 lines, -4 lines 0 comments Download
M components/test/data/autofill/merge/output/singlemerge.out View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Evan Stade
+Kyle for chrome/browser/extensions/api/autofill_private/autofill_util.cc +Rouslan for the rest
5 years, 6 months ago (2015-06-04 22:19:48 UTC) #2
Kyle Horimoto
lgtm
5 years, 6 months ago (2015-06-04 22:39:27 UTC) #3
please use gerrit instead
https://codereview.chromium.org/1143253012/diff/60001/components/autofill/core/browser/autofill_profile.cc File components/autofill/core/browser/autofill_profile.cc (right): https://codereview.chromium.org/1143253012/diff/60001/components/autofill/core/browser/autofill_profile.cc#newcode535 components/autofill/core/browser/autofill_profile.cc:535: l10n::CaseInsensitiveCompare compare; FYI, CaseInsensitiveCompare is surprisingly slow to construct. ...
5 years, 6 months ago (2015-06-04 23:24:28 UTC) #4
Evan Stade
https://codereview.chromium.org/1143253012/diff/60001/components/autofill/core/browser/autofill_profile.cc File components/autofill/core/browser/autofill_profile.cc (right): https://codereview.chromium.org/1143253012/diff/60001/components/autofill/core/browser/autofill_profile.cc#newcode535 components/autofill/core/browser/autofill_profile.cc:535: l10n::CaseInsensitiveCompare compare; On 2015/06/04 23:24:28, Rouslan wrote: > FYI, ...
5 years, 6 months ago (2015-06-05 00:39:08 UTC) #5
please use gerrit instead
lgtm You need an owner review for chrome/browser/sync/profile_sync_service_autofill_unittest.cc btw.
5 years, 6 months ago (2015-06-05 00:40:56 UTC) #6
Evan Stade
+zea for chrome/browser/sync/
5 years, 6 months ago (2015-06-05 00:48:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143253012/100001
5 years, 6 months ago (2015-06-05 18:48:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/32169)
5 years, 6 months ago (2015-06-05 20:48:58 UTC) #13
Nicolas Zea
lgtm
5 years, 6 months ago (2015-06-05 20:53:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143253012/120001
5 years, 6 months ago (2015-06-05 21:25:50 UTC) #17
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 6 months ago (2015-06-05 22:30:12 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 22:31:42 UTC) #19
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/431dfb72aedd23675487fc8df3ac927305fc494d
Cr-Commit-Position: refs/heads/master@{#333155}

Powered by Google App Engine
This is Rietveld 408576698