Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1143253011: Open source Tabs.* UMA stats (Closed)

Created:
5 years, 6 months ago by oshima
Modified:
5 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Open source Tabs.* UMA stats BUG=223859 R=jamescook@chromium.org, isherman@chromium.org Committed: https://crrev.com/57c64f59502ede094c8082401513894027c0a563 Cr-Commit-Position: refs/heads/master@{#332557}

Patch Set 1 #

Patch Set 2 : added obsolete uma #

Patch Set 3 : added dependent entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 6 chunks +276 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
oshima
5 years, 6 months ago (2015-06-02 22:21:48 UTC) #1
Ilya Sherman
Thanks! Happy to stamp this once you also send the inverse CL in google3.
5 years, 6 months ago (2015-06-02 22:28:59 UTC) #2
oshima
I added obsolete ones (SadTab.Displayed, SadTab.Created). PTAL
5 years, 6 months ago (2015-06-02 22:59:49 UTC) #3
Ilya Sherman
LGTM, thanks.
5 years, 6 months ago (2015-06-02 23:00:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143253011/20001
5 years, 6 months ago (2015-06-02 23:07:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/13190)
5 years, 6 months ago (2015-06-02 23:44:22 UTC) #8
chromium-reviews
Can you hold off on committing this? I'm having trouble on the google3 side. On ...
5 years, 6 months ago (2015-06-02 23:45:27 UTC) #9
oshima
On 2015/06/02 23:45:27, chromium-reviews wrote: > Can you hold off on committing this? I'm having ...
5 years, 6 months ago (2015-06-02 23:52:59 UTC) #10
oshima
uploaded new patch that incorporates new changes in https://critique.corp.google.com/#review/95061491 PTAL
5 years, 6 months ago (2015-06-03 00:58:28 UTC) #11
Ilya Sherman
LGTM
5 years, 6 months ago (2015-06-03 03:13:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143253011/40001
5 years, 6 months ago (2015-06-03 03:53:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-03 05:16:40 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 05:17:30 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/57c64f59502ede094c8082401513894027c0a563
Cr-Commit-Position: refs/heads/master@{#332557}

Powered by Google App Engine
This is Rietveld 408576698