Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 1143233003: Fix viewport scroll bubbling of wheel events in CC. (Closed)

Created:
5 years, 7 months ago by bokan
Modified:
5 years, 7 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix viewport scroll bubbling of wheel events in CC. The "LocalDelta" version of ScrollLayer in LTHI takes a scroll delta in viewport space and scrolls a layer in its local space. This means that the delta is scaled so that the scroll appears to be the same distance on the user's screen, regardless of the page scale factor (pinch-zoom). This method returns the amount consumed so that the caller can determine how much of the original scroll delta remains to bubble. However, the returned consumed delta is in local space, meaning we were subtracting a layer space delta from the viewport space delta. The practical effect of this was that when the page was scaled up the bubbling logic in the viewport would inappropriately bubble up scrolls to the inner (visual) viewport since the local delta is divided by the page scale factor. This caused position:fixed elements to "paralax" scroll with the page, cool looking but incorrect. BUG=488549 Committed: https://crrev.com/74efa3390f03912d5e734550d50601e096b9480e Cr-Commit-Position: refs/heads/master@{#330786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bokan
ptal. Thanks.
5 years, 7 months ago (2015-05-20 17:18:48 UTC) #2
bokan
looks like Alexandre's OOO, Ali, ptal?
5 years, 7 months ago (2015-05-20 17:20:10 UTC) #5
ajuma
lgtm
5 years, 7 months ago (2015-05-20 18:20:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143233003/1
5 years, 7 months ago (2015-05-20 18:21:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 19:50:20 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 19:51:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74efa3390f03912d5e734550d50601e096b9480e
Cr-Commit-Position: refs/heads/master@{#330786}

Powered by Google App Engine
This is Rietveld 408576698