Fixes the context menu for a notification.

ui/message_center/message_center_tray.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/message_center_tray.h"
 
 #include "base/observer_list.h"
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/message_center_tray_delegate.h"
 #include "ui/message_center/message_center_types.h"
 #include "ui/message_center/notification_blocker.h"
 
 namespace message_center {
 
+namespace {
+
+// Menu constants
+const int kTogglePermissionCommand = 0;
+const int kShowSettingsCommand = 1;
+
+}
+
 MessageCenterTray::MessageCenterTray(
     MessageCenterTrayDelegate* delegate,
     message_center::MessageCenter* message_center)
     : message_center_(message_center),
       message_center_visible_(false),
       popups_visible_(false),
-      delegate_(delegate) {
+      delegate_(delegate),
+      context_menu_notification_(NULL) {
   message_center_->AddObserver(this);
 }
 
 MessageCenterTray::~MessageCenterTray() {
   message_center_->RemoveObserver(this);
 }
 
 bool MessageCenterTray::ShowMessageCenterBubble() {
   if (message_center_visible_)
     return true;
@@ skipping 74 matching lines @@
 void MessageCenterTray::ShowNotifierSettingsBubble() {
   if (popups_visible_)
     HidePopupBubbleInternal();
 
   message_center_visible_ = delegate_->ShowNotifierSettings();
   message_center_->SetVisibility(message_center::VISIBILITY_SETTINGS);
 
   NotifyMessageCenterTrayChanged();
 }
 
+scoped_ptr<ui::MenuModel> MessageCenterTray::CreateMenuModelForNotification(
+    const std::string& id) {
+  scoped_ptr<ui::SimpleMenuModel> model(new ui::SimpleMenuModel(this));
+
+  // Find the notification for |id| to get the display source.
+  context_menu_notification_ = NULL;
+  const NotificationList::Notifications& notifications =
+      message_center_->GetVisibleNotifications();
+  for (NotificationList::Notifications::const_iterator iter =
+           notifications.begin(); iter != notifications.end(); ++iter) {
+    if ((*iter)->id() == id) {
+      context_menu_notification_ = *iter;
+      break;
+    }
+  }

[stevenjb, 2013/12/12 21:19:46]

This seems like it ought to be in MessageCenter, e.g.
context_menu_notification_ = message_center_->GetNotificationById(id);

[Jun Mukai, 2013/12/14 01:13:14]

This actually depends on the tray, for executing ShowNotifierSettingsBubble().

+  if (!context_menu_notification_)
+    return model.PassAs<ui::MenuModel>();
+
+  // Add 'disable notifications' menu item.
+  if (!context_menu_notification_->display_source().empty()) {
+    model->AddItem(kTogglePermissionCommand,
+                   l10n_util::GetStringFUTF16(
+                       IDS_MESSAGE_CENTER_NOTIFIER_DISABLE,
+                       context_menu_notification_->display_source()));
+  }
+  // Add settings menu item.
+  model->AddItem(kShowSettingsCommand,
+                 l10n_util::GetStringUTF16(IDS_MESSAGE_CENTER_SETTINGS));
+
+  return model.PassAs<ui::MenuModel>();
+}
+
 void MessageCenterTray::OnNotificationAdded(
     const std::string& notification_id) {
   OnMessageCenterChanged();
 }
 
 void MessageCenterTray::OnNotificationRemoved(
     const std::string& notification_id,
     bool by_user) {
   OnMessageCenterChanged();
 }
@@ skipping 22 matching lines @@
 }
 
 void MessageCenterTray::OnQuietModeChanged(bool in_quiet_mode) {
   NotifyMessageCenterTrayChanged();
 }
 
 void MessageCenterTray::OnBlockingStateChanged(NotificationBlocker* blocker) {
   OnMessageCenterChanged();
 }
 
+bool MessageCenterTray::IsCommandIdChecked(int command_id) const {
+  return false;
+}
+
+bool MessageCenterTray::IsCommandIdEnabled(int command_id) const {
+  return delegate_->IsContextMenuEnabled();
+}
+
+bool MessageCenterTray::GetAcceleratorForCommandId(
+    int command_id,
+    ui::Accelerator* accelerator) {
+  return false;
+}
+
+void MessageCenterTray::ExecuteCommand(int command_id, int event_flags) {
+  switch (command_id) {
+    case kTogglePermissionCommand:
+      message_center_->DisableNotificationsByNotifier(
+          context_menu_notification_->notifier_id());
+      break;
+    case kShowSettingsCommand:
+      ShowNotifierSettingsBubble();
+      break;
+    default:
+      NOTREACHED();
+  }
+}
+
+void MessageCenterTray::MenuClosed(ui::SimpleMenuModel* source) {
+  context_menu_notification_ = NULL;
+}
+
 void MessageCenterTray::OnMessageCenterChanged() {
   if (message_center_visible_ && message_center_->NotificationCount() == 0)
     HideMessageCenterBubble();
 
   if (popups_visible_ && !message_center_->HasPopupNotifications())
     HidePopupBubbleInternal();
   else if (!popups_visible_ && message_center_->HasPopupNotifications())
     ShowPopupBubble();
 
   NotifyMessageCenterTrayChanged();
 }
 
 void MessageCenterTray::NotifyMessageCenterTrayChanged() {
   delegate_->OnMessageCenterTrayChanged();
 }
 
 }  // namespace message_center