Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issue 1143223006: cc: Convert LayerTreeHostDamage tests to using PictureLayer. (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Convert LayerTreeHostDamage tests to using PictureLayer. This removes another use of ContentLayer in the unit tests preventing us from deleting non-impl-side-painting code. R=enne, vmpstr BUG=413479 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/552ffd9933d6dc0fbcd4fce4bb62b35145b30709 Cr-Commit-Position: refs/heads/master@{#333188}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -35 lines) Patch
M cc/trees/layer_tree_host_unittest_damage.cc View 9 chunks +32 lines, -35 lines 2 comments Download

Messages

Total messages: 8 (1 generated)
danakj
5 years, 6 months ago (2015-06-05 21:52:13 UTC) #1
enne (OOO)
https://codereview.chromium.org/1143223006/diff/1/cc/trees/layer_tree_host_unittest_damage.cc File cc/trees/layer_tree_host_unittest_damage.cc (left): https://codereview.chromium.org/1143223006/diff/1/cc/trees/layer_tree_host_unittest_damage.cc#oldcode309 cc/trees/layer_tree_host_unittest_damage.cc:309: gfx::RectF paint_rect = child_->LastPaintRect(); Why is this not needed ...
5 years, 6 months ago (2015-06-05 22:17:11 UTC) #2
danakj
https://codereview.chromium.org/1143223006/diff/1/cc/trees/layer_tree_host_unittest_damage.cc File cc/trees/layer_tree_host_unittest_damage.cc (left): https://codereview.chromium.org/1143223006/diff/1/cc/trees/layer_tree_host_unittest_damage.cc#oldcode309 cc/trees/layer_tree_host_unittest_damage.cc:309: gfx::RectF paint_rect = child_->LastPaintRect(); On 2015/06/05 22:17:10, enne wrote: ...
5 years, 6 months ago (2015-06-05 23:09:08 UTC) #3
enne (OOO)
Talked offline. Paint rect not important, and it's already checking the damage rect, which seems ...
5 years, 6 months ago (2015-06-06 00:06:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143223006/1
5 years, 6 months ago (2015-06-06 00:07:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-06 00:47:57 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 00:49:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/552ffd9933d6dc0fbcd4fce4bb62b35145b30709
Cr-Commit-Position: refs/heads/master@{#333188}

Powered by Google App Engine
This is Rietveld 408576698