Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1143223002: [Password manager tests automation] Improves redability of code and logs. (Closed)

Created:
5 years, 7 months ago by melandory
Modified:
5 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password manager tests automation] Improves redability of code and logs. * Removes succesfull runs from debug output. * Use named parameter in call to stopit.ThreadingTimeout, in order to make it clear that it seconds. BUG=369521 R=vabr@chromium.org Committed: https://crrev.com/69bcb8eb5879ab2fd4ad03665f612ccff90c1cc6 Cr-Commit-Position: refs/heads/master@{#330743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M components/test/data/password_manager/automated_tests/run_tests.py View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
melandory
Hi Vaclav, review this Cl, please.
5 years, 7 months ago (2015-05-20 14:12:31 UTC) #1
vabr (Chromium)
lgtm
5 years, 7 months ago (2015-05-20 14:50:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143223002/1
5 years, 7 months ago (2015-05-20 15:06:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 16:03:44 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 16:04:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69bcb8eb5879ab2fd4ad03665f612ccff90c1cc6
Cr-Commit-Position: refs/heads/master@{#330743}

Powered by Google App Engine
This is Rietveld 408576698