Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1143213003: Add hb-ot-font.cc and hb-ot-font.h (Closed)

Created:
5 years, 7 months ago by kojii
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add hb-ot-font.cc and hb-ot-font.h This patch includes hb-ot-font.cc and hb-ot-font.h into our builds. These files are available since harfbuzz-ng 0.9.28. This patch also contains a cherry-pick below to fix a build warning. https://github.com/behdad/harfbuzz/commit/f1b44303df0712b433e35e1e1e75115c353b279e BUG=383580 Committed: https://crrev.com/0313dc8a6205bf6c7934c7e7927604eac1d9b027 Cr-Commit-Position: refs/heads/master@{#331666}

Patch Set 1 #

Patch Set 2 : Switch PR to a landed commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-font.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
kojii
PTAL.
5 years, 7 months ago (2015-05-20 17:31:04 UTC) #2
eae
Do we need those files? Given that no tests needed updating and there are no ...
5 years, 7 months ago (2015-05-26 22:39:04 UTC) #4
behdad_google
On 2015/05/26 22:39:04, eae wrote: > Do we need those files? Given that no tests ...
5 years, 7 months ago (2015-05-26 22:44:34 UTC) #5
eae
On 2015/05/26 22:44:34, behdad_google wrote: > On 2015/05/26 22:39:04, eae wrote: > > Do we ...
5 years, 7 months ago (2015-05-26 22:45:21 UTC) #6
kojii
On 2015/05/26 22:39:04, eae wrote: > Do we need those files? Given that no tests ...
5 years, 7 months ago (2015-05-27 00:09:21 UTC) #7
eae
LGTM
5 years, 7 months ago (2015-05-27 19:40:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143213003/40001
5 years, 7 months ago (2015-05-27 19:41:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-27 21:59:56 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 22:00:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0313dc8a6205bf6c7934c7e7927604eac1d9b027
Cr-Commit-Position: refs/heads/master@{#331666}

Powered by Google App Engine
This is Rietveld 408576698