Issue 1143153011: Refactor padding out of RenderBlock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1143153011: Refactor padding out of RenderBlock. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Refactor padding out of RenderBlock. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/399614a8ebe1d575ef1298e23524481030b1c1f0

Patch Set 2 : fix hit testing #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -52 lines)			Patch
	M	sky/examples/raw/simple_render_tree.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download
	M	sky/sdk/lib/framework/layout2.dart	View	1	13 chunks	+105 lines, -48 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1143153011/diff/1/sky/sdk/lib/framework/layout2.dart File sky/sdk/lib/framework/layout2.dart (right): https://codereview.chromium.org/1143153011/diff/1/sky/sdk/lib/framework/layout2.dart#newcode591 sky/sdk/lib/framework/layout2.dart:591: } hitTestChildren?

5 years, 6 months ago (2015-05-27 23:50:03 UTC) #2

Hixie

5 years, 6 months ago (2015-05-28 00:11:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
399614a8ebe1d575ef1298e23524481030b1c1f0 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1143153011: Refactor padding out of RenderBlock. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix hit testing #

Messages