Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4246)

Unified Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.cc

Issue 1143153010: [Android] Add enhanced bookmarks grid/list view experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/enhanced_bookmarks_features.cc
diff --git a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
index bbe6335092052daa33d525ef524a42d0f10c7076..84e840cc675bccd7a5dedaa458a693fe7b803e36 100644
--- a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
+++ b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
@@ -7,6 +7,7 @@
#include "base/command_line.h"
#include "base/prefs/pref_service.h"
#include "chrome/common/chrome_switches.h"
+#include "components/enhanced_bookmarks/enhanced_bookmark_utils.h"
#include "components/variations/variations_associated_data.h"
#if !defined(OS_ANDROID) && !defined(OS_IOS)
@@ -16,10 +17,9 @@
namespace {
-const char kFieldTrialName[] = "EnhancedBookmarks";
-
bool GetBookmarksExperimentExtensionID(std::string* extension_id) {
- *extension_id = variations::GetVariationParamValue(kFieldTrialName, "id");
+ *extension_id = variations::GetVariationParamValue(
+ enhanced_bookmarks::kFieldTrialName, "id");
if (extension_id->empty())
return false;
@@ -46,7 +46,7 @@ bool IsEnhancedBookmarkImageFetchingEnabled(const PrefService* user_prefs) {
// experience is not a big list of flat colors. However as a precautionary
// measure it is possible to disable this collection of images from finch.
std::string disable_fetching = variations::GetVariationParamValue(
- kFieldTrialName, "DisableImagesFetching");
+ enhanced_bookmarks::kFieldTrialName, "DisableImagesFetching");
return disable_fetching.empty();
}
#endif // defined(OS_ANDROID)
@@ -83,8 +83,8 @@ bool IsEnableDomDistillerSet() {
switches::kEnableDomDistiller)) {
return true;
}
- if (variations::GetVariationParamValue(
- kFieldTrialName, "enable-dom-distiller") == "1")
+ if (variations::GetVariationParamValue(enhanced_bookmarks::kFieldTrialName,
+ "enable-dom-distiller") == "1")
return true;
return false;
@@ -95,8 +95,8 @@ bool IsEnableSyncArticlesSet() {
switches::kEnableSyncArticles)) {
return true;
}
- if (variations::GetVariationParamValue(
- kFieldTrialName, "enable-sync-articles") == "1")
+ if (variations::GetVariationParamValue(enhanced_bookmarks::kFieldTrialName,
+ "enable-sync-articles") == "1")
return true;
return false;

Powered by Google App Engine
This is Rietveld 408576698