Issue 1143133007: Revert "Add a Color class to dart:sky."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1143133007: Revert "Add a Color class to dart:sky." (Closed)

Created:
5 years, 6 months ago by Matt Perry

Modified:
5 years, 6 months ago

Reviewers:
jackson

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, abarth-chromium

Base URL:
git@github.com:/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert "Add a Color class to dart:sky." This reverts commit a413c8319fe9a46dc131f6efe275d014c9cb7eb9. Reason: seems to have broken Sky tests: Regressions: Unexpected crashes (2) raw/render_box.dart [ Crash ] raw/render_flex.dart [ Crash ] TBR=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1c89f47bf70945031dd1272357f43a1991b26013

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -117 lines)			Patch
M	sky/engine/bindings/scripts/dart_types.py	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	sky/engine/core/core.gni	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	sky/engine/core/painting/CanvasColor.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	sky/engine/core/painting/CanvasColor.cpp	View	1 chunk	+0 lines, -45 lines	0 comments	Download
D	sky/engine/core/painting/Color.dart	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	sky/engine/core/painting/Paint.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/painting/Paint.idl	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/script/dom_dart_state.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/script/dom_dart_state.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	sky/examples/raw/painting.sky	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 3 (1 generated)

Matt Perry

5 years, 6 months ago (2015-06-01 22:13:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1c89f47bf70945031dd1272357f43a1991b26013 (presubmit successful).