Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1143073007: [KeyboardEvent] DOM |Key| support in dispatchKeyEvent (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[KeyboardEvent] DOM |Key| support in dispatchKeyEvent Updated dispatchKeyEvent in the inputHandler as protocol.json is updated with additional parameter for the domKey. R= dgozman, pfeldman BUG=227231 Committed: https://crrev.com/bb338c90f33f7f9ce67b56b293f255bb473c1c5d Cr-Commit-Position: refs/heads/master@{#332406}

Patch Set 1 #

Patch Set 2 : DOM |Key| support in devTools #

Patch Set 3 : Leaves the current version intact and adds a new function with extra parameter to support DOM |Key| #

Total comments: 2

Patch Set 4 : Instead of copying it reuses other function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M content/browser/devtools/protocol/input_handler.h View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 1 2 3 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Habib Virji
Had dependency on the blink side: https://codereview.chromium.org/1157563008/ This commit is based on the comment from ...
5 years, 6 months ago (2015-06-02 12:15:31 UTC) #1
dgozman
Note that due to code generation and different repos, you will need 3 patches: - ...
5 years, 6 months ago (2015-06-02 12:30:46 UTC) #2
Habib Virji
Done. Will upload cleanup once the code lands. So the process of landing will be ...
5 years, 6 months ago (2015-06-02 12:40:00 UTC) #3
dgozman
> So the process of landing will be first chromium side > changes will land ...
5 years, 6 months ago (2015-06-02 13:22:01 UTC) #4
Habib Virji
https://codereview.chromium.org/1143073007/diff/40001/content/browser/devtools/protocol/input_handler.cc File content/browser/devtools/protocol/input_handler.cc (right): https://codereview.chromium.org/1143073007/diff/40001/content/browser/devtools/protocol/input_handler.cc#newcode215 content/browser/devtools/protocol/input_handler.cc:215: Response InputHandler::DispatchKeyEvent( On 2015/06/02 13:22:01, dgozman wrote: > Please ...
5 years, 6 months ago (2015-06-02 14:15:20 UTC) #5
dgozman
lgtm
5 years, 6 months ago (2015-06-02 15:25:39 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143073007/60001
5 years, 6 months ago (2015-06-02 15:27:21 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-02 16:25:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143073007/60001
5 years, 6 months ago (2015-06-02 16:27:11 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-02 16:32:31 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 16:33:19 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bb338c90f33f7f9ce67b56b293f255bb473c1c5d
Cr-Commit-Position: refs/heads/master@{#332406}

Powered by Google App Engine
This is Rietveld 408576698