Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 1143073006: [Android] Add workaround to update verification script for Mac. (Closed)

Created:
5 years, 7 months ago by mikecase (-- gone --)
Modified:
5 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add workaround to update verification script for Mac. It seems like the aapt binary which pylib uses to get the package name from an apk doesn't run on Macs. Adding an argument to the script to be able to manually specify the package name so Mac users can use this script. BUG= Committed: https://crrev.com/06ef720caae28f262ec40804b85838a3fa1654a1 Cr-Commit-Position: refs/heads/master@{#331222}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Addressed jbudorick's nits. Added exception if no device is found. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M build/android/update_verification.py View 1 2 2 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mikecase (-- gone --)
Work around so some of the manual testers with Macs can run this script.
5 years, 7 months ago (2015-05-22 23:19:13 UTC) #2
jbudorick
lgtm w/ nit https://codereview.chromium.org/1143073006/diff/20001/build/android/update_verification.py File build/android/update_verification.py (right): https://codereview.chromium.org/1143073006/diff/20001/build/android/update_verification.py#newcode95 build/android/update_verification.py:95: package_name = (args.package_name if args.package_name nit: ...
5 years, 7 months ago (2015-05-22 23:23:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143073006/40001
5 years, 7 months ago (2015-05-22 23:57:47 UTC) #6
mikecase (-- gone --)
https://codereview.chromium.org/1143073006/diff/20001/build/android/update_verification.py File build/android/update_verification.py (right): https://codereview.chromium.org/1143073006/diff/20001/build/android/update_verification.py#newcode95 build/android/update_verification.py:95: package_name = (args.package_name if args.package_name On 2015/05/22 at 23:23:31, ...
5 years, 7 months ago (2015-05-22 23:58:48 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-23 02:30:15 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-23 02:31:12 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/06ef720caae28f262ec40804b85838a3fa1654a1
Cr-Commit-Position: refs/heads/master@{#331222}

Powered by Google App Engine
This is Rietveld 408576698