Issue 1143073004: Move 'dart:mojo.internal' into sdk_ext directory of mojo package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1143073004: Move 'dart:mojo.internal' into sdk_ext directory of mojo package (Closed)

Created:
5 years, 7 months ago by Cutch

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move 'dart:mojo.internal' into sdk_ext directory of mojo package BUG= R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/12f7254f939dbfb48eb1ead398d9adfe2f3c657c

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -501 lines)			Patch
M	mojo/dart/embedder/BUILD.gn	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	mojo/public/dart/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
D	mojo/public/dart/lib/internal.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	mojo/public/dart/lib/src/handle_watcher.dart	View	1 chunk	+0 lines, -353 lines	0 comments	Download
D	mojo/public/dart/lib/src/natives.dart	View	1 chunk	+0 lines, -70 lines	0 comments	Download
D	mojo/public/dart/lib/src/timer_queue.dart	View	1 chunk	+0 lines, -53 lines	0 comments	Download
A +	mojo/public/dart/sdk_ext/internal.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	mojo/public/dart/sdk_ext/src/handle_watcher.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	mojo/public/dart/sdk_ext/src/natives.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	mojo/public/dart/sdk_ext/src/timer_queue.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sky/engine/bindings/BUILD.gn	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/dart/patch_sdk.diff	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

5 years, 7 months ago (2015-05-21 18:02:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
12f7254f939dbfb48eb1ead398d9adfe2f3c657c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages