Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1143053006: Add std::string versions of URLRequestMockHTTPJob::GetMockUrl and GetMockHttpsUrl. (Closed)

Created:
5 years, 6 months ago by mattm
Modified:
5 years, 6 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add std::string versions of URLRequestMockHTTPJob::GetMockUrl and GetMockHttpsUrl. BUG=496936 Committed: https://crrev.com/5b84a64eaed7edea18140790ef56ef899ac1010a Cr-Commit-Position: refs/heads/master@{#333071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M net/test/url_request/url_request_mock_http_job.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/test/url_request/url_request_mock_http_job.cc View 2 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mattm
5 years, 6 months ago (2015-06-05 01:06:32 UTC) #2
mmenke
LGTM
5 years, 6 months ago (2015-06-05 15:13:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143053006/1
5 years, 6 months ago (2015-06-05 16:42:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 16:53:41 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 16:54:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b84a64eaed7edea18140790ef56ef899ac1010a
Cr-Commit-Position: refs/heads/master@{#333071}

Powered by Google App Engine
This is Rietveld 408576698