Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(41)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1143043006: Cleanup: Move ChromeClient::m_lastSetMouseCursorForTesting to ChromeClientImpl. (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cleanup: Move ChromeClient::m_lastSetMouseCursorForTesting to ChromeClientImpl. This member is unnecessary for ChromeClient implementations other than ChromeClientImpl. We can eliminate setCursor/setCursorInternal separation by moving it. BUG=495378 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M Source/core/loader/EmptyClients.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/page/ChromeClient.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
yosin@, please review this.
4 years, 11 months ago (2015-06-04 03:13:20 UTC) #2
yosin_UTC9
lgtm Thanks for cleanup!
4 years, 11 months ago (2015-06-04 03:33:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143043006/1
4 years, 11 months ago (2015-06-04 03:34:57 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 04:34:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196454

Powered by Google App Engine
This is Rietveld 408576698