Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 1143043004: Speed up "gn path". (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speed up "gn path". "gn path" finds all unique paths. This can be slow because, for example, //chrome/browser has 478 million unique paths through it's dependency tree and running path from //chrome/browser to //chrome/renderer took about 6.5 seconds on my big desktop to analyze all of these (to find no results). This patch keeps track of which targets have been eliminated from consideration and avoids visiting them again. This improves the above qwuery to 0.78 seconds while still being able to compute the total number of results. Committed: https://crrev.com/22ca12c760e23efdc988409149fd2d4e43e6fed9 Cr-Commit-Position: refs/heads/master@{#330772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M tools/gn/command_path.cc View 5 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 7 months ago (2015-05-20 16:45:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143043004/1
5 years, 7 months ago (2015-05-20 16:46:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 17:00:06 UTC) #6
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-20 17:33:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143043004/1
5 years, 7 months ago (2015-05-20 18:08:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 18:12:55 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 18:13:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22ca12c760e23efdc988409149fd2d4e43e6fed9
Cr-Commit-Position: refs/heads/master@{#330772}

Powered by Google App Engine
This is Rietveld 408576698